Re: [PATCH v2 5/9] s390x/pci: create a header dedicated to PCI CLP

[Cornelia Huck]

On Fri,  2 Oct 2020 16:06:27 -0400
Matthew Rosato <mjrosato@linux.ibm.com> wrote:

> From: Pierre Morel <pmorel@linux.ibm.com>
> 
> To have a clean separation between s390-pci-bus.h and s390-pci-inst.h
> headers we export the PCI CLP instructions in a dedicated header.
> 
> Signed-off-by: Pierre Morel <pmorel@linux.ibm.com>
> Signed-off-by: Matthew Rosato <mjrosato@linux.ibm.com>
> ---
>  include/hw/s390x/s390-pci-bus.h  |   1 +
>  include/hw/s390x/s390-pci-clp.h  | 211 
> +++++++++++++++++++++++++++++++++++++++
>  include/hw/s390x/s390-pci-inst.h | 196 ------------------------------------
>  3 files changed, 212 insertions(+), 196 deletions(-)
>  create mode 100644 include/hw/s390x/s390-pci-clp.h 

(...)

> diff --git a/include/hw/s390x/s390-pci-clp.h b/include/hw/s390x/s390-pci-clp.h
> new file mode 100644
> index 0000000..e442307
> --- /dev/null
> +++ b/include/hw/s390x/s390-pci-clp.h
> @@ -0,0 +1,211 @@
> +/*
> + * s390 CLPinstruction definitions

s/CLPinstruction/CLP instruction/ ?

> + *
> + * Copyright 2019 IBM Corp.
> + * Author(s): Pierre Morel <pmorel@de.ibm.com>
> + *
> + * This work is licensed under the terms of the GNU GPL, version 2 or (at
> + * your option) any later version. See the COPYING file in the top-level
> + * directory.
> + */

(...)

Reviewed-by: Cornelia Huck <cohuck@redhat.com>