[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/5] qom: Remove module_obj_name parameter from OBJECT_DECLAR
|
From: |
Cornelia Huck |
|
Subject: |
Re: [PATCH 3/5] qom: Remove module_obj_name parameter from OBJECT_DECLARE* macros |
|
Date: |
Thu, 17 Sep 2020 09:46:57 +0200 |
On Wed, 16 Sep 2020 14:25:17 -0400
Eduardo Habkost <ehabkost@redhat.com> wrote:
> One of the goals of having less boilerplate on QOM declarations
> is to avoid human error. Requiring an extra argument that is
> never used is an opportunity for mistakes.
>
> Remove the unused argument from OBJECT_DECLARE_TYPE and
> OBJECT_DECLARE_SIMPLE_TYPE.
>
> Coccinelle patch used to convert all users of the macros:
>
> @@
> declarer name OBJECT_DECLARE_TYPE;
> identifier InstanceType, ClassType, lowercase, UPPERCASE;
> @@
> OBJECT_DECLARE_TYPE(InstanceType, ClassType,
> - lowercase,
> UPPERCASE);
>
> @@
> declarer name OBJECT_DECLARE_SIMPLE_TYPE;
> identifier InstanceType, lowercase, UPPERCASE;
> @@
> OBJECT_DECLARE_SIMPLE_TYPE(InstanceType,
> - lowercase,
> UPPERCASE);
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Acked-by: Cornelia Huck <cohuck@redhat.com>