qemu-s390x
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v1 10/17] virtio-mem: Paravirtualized memory hot(un)plug


From: David Hildenbrand
Subject: Re: [PATCH v1 10/17] virtio-mem: Paravirtualized memory hot(un)plug
Date: Mon, 18 May 2020 16:23:09 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0

>>> +
>>> +static int virtio_mem_pre_save(void *opaque)
>>> +{
>>> +    VirtIOMEM *vmem = VIRTIO_MEM(opaque);
>>> +
>>> +    vmem->migration_addr = vmem->addr;
>>> +    vmem->migration_block_size = vmem->block_size;
>>
>> You might look at VMSTATE_WITH_TMP could avoid you having the dummy
>> fields.
> 
> Thanks, will have a look.

VMSTATE_WITH_TMP looks too complicated for this simple use case. I'll
just drop these migration sanity checks for now.

Thanks!

-- 
Thanks,

David / dhildenb




reply via email to

[Prev in Thread] Current Thread [Next in Thread]