[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 01/12] Makefile: Only build virtiofsd if system-mode is en
|
From: |
Dr. David Alan Gilbert |
|
Subject: |
Re: [PATCH v3 01/12] Makefile: Only build virtiofsd if system-mode is enabled |
|
Date: |
Mon, 18 May 2020 13:14:34 +0100 |
|
User-agent: |
Mutt/1.13.4 (2020-02-15) |
* Philippe Mathieu-Daudé (address@hidden) wrote:
> Do not build the virtiofsd helper when configured with
> --disable-system.
>
> Reviewed-by: Richard Henderson <address@hidden>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Yeh that seems reasonable; although virtiofsd is self-contained enough
that perhaps it should be unrelated to whether you're building that.
Acked-by: Dr. David Alan Gilbert <address@hidden>
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 34275f57c9..e46b6ef5d4 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -345,7 +345,7 @@ HELPERS-y += vhost-user-gpu$(EXESUF)
> vhost-user-json-y += contrib/vhost-user-gpu/50-qemu-gpu.json
> endif
>
> -ifeq ($(CONFIG_LINUX)$(CONFIG_SECCOMP)$(CONFIG_LIBCAP_NG),yyy)
> +ifeq
> ($(CONFIG_SOFTMMU)$(CONFIG_LINUX)$(CONFIG_SECCOMP)$(CONFIG_LIBCAP_NG),yyyy)
> HELPERS-y += virtiofsd$(EXESUF)
> vhost-user-json-y += tools/virtiofsd/50-qemu-virtiofsd.json
> endif
> --
> 2.21.3
>
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
- [PATCH v3 00/12] user-mode: Prune build dependencies (part 1), Philippe Mathieu-Daudé, 2020/05/04
- [PATCH v3 01/12] Makefile: Only build virtiofsd if system-mode is enabled, Philippe Mathieu-Daudé, 2020/05/04
- Re: [PATCH v3 01/12] Makefile: Only build virtiofsd if system-mode is enabled,
Dr. David Alan Gilbert <=
- [PATCH v3 02/12] configure: Avoid building TCG when not needed, Philippe Mathieu-Daudé, 2020/05/04
- [PATCH v3 03/12] tests/Makefile: Only display TCG-related tests when TCG is available, Philippe Mathieu-Daudé, 2020/05/04
- [PATCH v3 04/12] tests/Makefile: Restrict some softmmu-only tests, Philippe Mathieu-Daudé, 2020/05/04
- [PATCH v3 05/12] util/Makefile: Reduce the user-mode object list, Philippe Mathieu-Daudé, 2020/05/04
- [PATCH v3 06/12] stubs/Makefile: Reduce the user-mode object list, Philippe Mathieu-Daudé, 2020/05/04
- [PATCH v3 07/12] target/riscv/cpu: Restrict CPU migration to system-mode, Philippe Mathieu-Daudé, 2020/05/04
- [PATCH v3 08/12] exec: Assert CPU migration is not used on user-only build, Philippe Mathieu-Daudé, 2020/05/04
- [PATCH v3 09/12] arch_init: Remove unused 'qapi-commands-misc.h' include, Philippe Mathieu-Daudé, 2020/05/04