Re: [PATCH 02/10] exec/ramblock: Add missing 'qemu/rcu.h' include

qemu-s390x

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 02/10] exec/ramblock: Add missing 'qemu/rcu.h' include

From:	Juan Quintela
Subject:	Re: [PATCH 02/10] exec/ramblock: Add missing 'qemu/rcu.h' include
Date:	Fri, 08 May 2020 09:59:59 +0200
User-agent:	Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)

Philippe Mathieu-Daudé <address@hidden> wrote:
> The first field of RAMBlock is a rcu_head structure.
> We need to include the "qemu/rcu.h" to avoid errors when
> including "exec/ramblock.h" without "qemu/rcu.h":
>
>   include/exec/ramblock.h:27:21: error: field ‘rcu’ has incomplete type
>      27 |     struct rcu_head rcu;
>         |                     ^~~
>   include/exec/ramblock.h:39:5: error: expected
> specifier-qualifier-list before ‘QLIST_ENTRY’
>      39 |     QLIST_ENTRY(RAMBlock) next;
>         |     ^~~~~~~~~~~
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>

Reviewed-by: Juan Quintela <address@hidden>

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH 00/10] exec: Shear 'exec/ram_addr.h' and make NVMe device target-agnostic, Philippe Mathieu-Daudé, 2020/05/07
- [PATCH 01/10] exec: Rename qemu_ram_writeback() as qemu_ram_msync(), Philippe Mathieu-Daudé, 2020/05/07
  - Re: [PATCH 01/10] exec: Rename qemu_ram_writeback() as qemu_ram_msync(), Juan Quintela, 2020/05/08
- [PATCH 02/10] exec/ramblock: Add missing 'qemu/rcu.h' include, Philippe Mathieu-Daudé, 2020/05/07
  - Re: [PATCH 02/10] exec/ramblock: Add missing 'qemu/rcu.h' include, Juan Quintela <=
- [PATCH 03/10] exec: Move tb_invalidate_phys_range() to 'exec/exec-all.h', Philippe Mathieu-Daudé, 2020/05/07
- [PATCH 04/10] exec/memory-internal: Check CONFIG_SOFTMMU instead of CONFIG_USER_ONLY, Philippe Mathieu-Daudé, 2020/05/07
  - Re: [PATCH 04/10] exec/memory-internal: Check CONFIG_SOFTMMU instead of CONFIG_USER_ONLY, Juan Quintela, 2020/05/08
- [PATCH 05/10] exec: Move qemu_minrampagesize/qemu_maxrampagesize to 'qemu-common.h', Philippe Mathieu-Daudé, 2020/05/07
  - Re: [PATCH 05/10] exec: Move qemu_minrampagesize/qemu_maxrampagesize to 'qemu-common.h', Juan Quintela, 2020/05/08
  - Re: [PATCH 05/10] exec: Move qemu_minrampagesize/qemu_maxrampagesize to 'qemu-common.h', Cornelia Huck, 2020/05/08
  - Re: [PATCH 05/10] exec: Move qemu_minrampagesize/qemu_maxrampagesize to 'qemu-common.h', David Gibson, 2020/05/10
- [PATCH 06/10] exec: Move ramblock_recv_bitmap_offset() to migration/ram.c, Philippe Mathieu-Daudé, 2020/05/07
  - Re: [PATCH 06/10] exec: Move ramblock_recv_bitmap_offset() to migration/ram.c, Juan Quintela, 2020/05/08
    - Re: [PATCH 06/10] exec: Move ramblock_recv_bitmap_offset() to migration/ram.c, Philippe Mathieu-Daudé, 2020/05/08

Prev by Date: Re: [PATCH 01/10] exec: Rename qemu_ram_writeback() as qemu_ram_msync()
Next by Date: Re: [PATCH 04/10] exec/memory-internal: Check CONFIG_SOFTMMU instead of CONFIG_USER_ONLY
Previous by thread: [PATCH 02/10] exec/ramblock: Add missing 'qemu/rcu.h' include
Next by thread: [PATCH 03/10] exec: Move tb_invalidate_phys_range() to 'exec/exec-all.h'
Index(es):
- Date
- Thread