Re: [PATCH v10 15/16] docs: system: Add protvirt docs

[Janosch Frank]

On 3/18/20 3:53 PM, Cornelia Huck wrote:
> On Wed, 18 Mar 2020 10:30:46 -0400
> Janosch Frank <address@hidden> wrote:
> 
>> Let's add some documentation for the Protected VM functionality.
>>
>> Signed-off-by: Janosch Frank <address@hidden>
>> Acked-by: David Hildenbrand <address@hidden>
>> Reviewed-by: Claudio Imbrenda <address@hidden>
>> ---
>>  docs/system/s390x/protvirt.rst | 59 ++++++++++++++++++++++++++++++++++
>>  docs/system/target-s390x.rst   |  5 +++
>>  2 files changed, 64 insertions(+)
>>  create mode 100644 docs/system/s390x/protvirt.rst
> 
> (...)
> 
>> +Booting from the image supplied on the QEMU command line requires that
>> +the file passed via -kernel has the same memory layout as would result
>> +from the disk boot. This memory layout includes the encrypted
>> +components (kernel, initrd, cmdline), the stage3a loader and
>> +metadata. In case this boot method is used, the command line
>> +options -initrd and -cmdline are ineffective. The preparation of a PVM
>> +image is done via the `genprotimg` tool from the s390-tools package.
> 
> I still think 'package' is not a good name (yes, I realize that
> s390-tools' README uses that term as well :) I'd prefer 'collection' or
> something like that, so it doesn't get confused with distro packages,
> which may use a different name. But no strong opinion.

collection it is

> 
>> diff --git a/docs/system/target-s390x.rst b/docs/system/target-s390x.rst
>> index 4c8b7cdd66154d26..8d97158dc804af1c 100644
>> --- a/docs/system/target-s390x.rst
>> +++ b/docs/system/target-s390x.rst
>> @@ -24,3 +24,8 @@ or vfio-ap is also available.
>>  .. toctree::
>>     s390x/vfio-ap
>>  
>> +Architectural features
>> +~~~~~~~~
> 
> Architecture features
> =====================
> 
> ?

Ack

> 
>> +
>> +.. toctree::
>> +   s390x/protvirt
> 
> Otherwise, looks good to me.
> 
>

signature.asc
Description: OpenPGP digital signature