Re: [PATCH v9 13/15] s390x: protvirt: Handle SIGP store status correctly

[Janosch Frank]

On 3/12/20 4:51 PM, Christian Borntraeger wrote:
> On 11.03.20 14:21, Janosch Frank wrote:
>> For protected VMs status storing is not done by QEMU anymore.
>>
>> Signed-off-by: Janosch Frank <address@hidden>
>> Reviewed-by: Thomas Huth <address@hidden>
>> Reviewed-by: David Hildenbrand <address@hidden>
> 
> 
>> ---
>>  target/s390x/helper.c | 6 ++++++
>>  1 file changed, 6 insertions(+)
>>
>> diff --git a/target/s390x/helper.c b/target/s390x/helper.c
>> index ed726849114f2f35..5022df8812d406c9 100644
>> --- a/target/s390x/helper.c
>> +++ b/target/s390x/helper.c
>> @@ -25,6 +25,7 @@
>>  #include "qemu/timer.h"
>>  #include "qemu/qemu-print.h"
>>  #include "hw/s390x/ioinst.h"
>> +#include "hw/s390x/pv.h"
>>  #include "sysemu/hw_accel.h"
>>  #include "sysemu/runstate.h"
>>  #ifndef CONFIG_USER_ONLY
>> @@ -246,6 +247,11 @@ int s390_store_status(S390CPU *cpu, hwaddr addr, bool 
>> store_arch)
>>      hwaddr len = sizeof(*sa);
>>      int i;
>>  
>> +    /* Storing will occur on next SIE entry for protected VMs */
> 
> Maybe ... next SIE entry of the sending CPU .... 
> ?

Well that would be the current cpu, right?
So:
/* For PVMs storing will occur when this cpu enters SIE again */

> 
> Reviewed-by: Christian Borntraeger <address@hidden>
> 
> 
>> +    if (s390_is_pv()) {
>> +        return 0;
>> +    }
>> +
>>      sa = cpu_physical_memory_map(addr, &len, true);
>>      if (!sa) {
>>          return -EFAULT;
>>

signature.asc
Description: OpenPGP digital signature