[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/1] s390/ipl: sync back loadparm
|
From: |
Christian Borntraeger |
|
Subject: |
Re: [PATCH v2 1/1] s390/ipl: sync back loadparm |
|
Date: |
Tue, 10 Mar 2020 09:42:11 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 |
On 09.03.20 14:32, Halil Pasic wrote:
> We expose loadparm as a r/w machine property, but if loadparm is set by
> the guest via DIAG 308, we don't update the property. Having a
> disconnect between the guest view and the QEMU property is not nice in
> itself, but things get even worse for SCSI, where under certain
> circumstances (see 789b5a401b "s390: Ensure IPL from SCSI works as
> expected" for details) we call s390_gen_initial_iplb() on resets
> effectively overwriting the guest/user supplied loadparm with the stale
> value.
>
> Signed-off-by: Halil Pasic <address@hidden>
> Fixes: 7104bae9de ("hw/s390x: provide loadparm property for the machine")
> Reported-by: Marc Hartmayer <address@hidden>
> Reviewed-by: Janosch Frank <address@hidden>
> Reviewed-by: Viktor Mihajlovski <address@hidden>
> Tested-by: Marc Hartmayer <address@hidden>
Thanks applied with the reverse xmas tree change.