[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] mem-prealloc: initialize cond and mutex
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [PATCH] mem-prealloc: initialize cond and mutex |
|
Date: |
Mon, 9 Mar 2020 11:05:29 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
On 09/03/20 11:03, Igor Mammedov wrote:
>> + qemu_cond_init(&page_cond);
>> + qemu_mutex_init(&page_mutex);
> Is it possible for touch_all_pages to be called several times?
> If it's then it probably needs a guard against that to make
> sure it won't explode, something like:
>
> static bool page_mutex_inited;
>
> if(page_mutex_inited)
> page_mutex_inited = true
> qemu_mutex_init(&page_mutex)
> ...
>
Hmm, good idea, it should also use GOnce.
Paolo
- [PATCH] mem-prealloc: initialize cond and mutex, Christian Borntraeger, 2020/03/06
- Re: [PATCH] mem-prealloc: initialize cond and mutex, Paolo Bonzini, 2020/03/06
- 回复: [PATCH] mem-prealloc: initialize cond and mutex(Internet mail), 陈蒙蒙, 2020/03/06
- Re: [PATCH] mem-prealloc: initialize cond and mutex, Igor Mammedov, 2020/03/09
- Re: [PATCH] mem-prealloc: initialize cond and mutex,
Paolo Bonzini <=
- Re: [PATCH] mem-prealloc: initialize cond and mutex, Christian Borntraeger, 2020/03/09
- Re: Re: [PATCH] mem-prealloc: initialize cond and mutex(Internet mail), 陈蒙蒙, 2020/03/09
- Re: [PATCH] mem-prealloc: initialize cond and mutex(Internet mail), Igor Mammedov, 2020/03/09
- Re: Re: [PATCH] mem-prealloc: initialize cond and mutex(Internet mail), 陈蒙蒙, 2020/03/10
- Re: [PATCH] mem-prealloc: initialize cond and mutex(Internet mail), Paolo Bonzini, 2020/03/11
- Re: Re: [PATCH] mem-prealloc: initialize cond and mutex(Internet mail), 陈蒙蒙, 2020/03/12