[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 14/18] s390x: protvirt: Move IO control structures over SI
|
From: |
David Hildenbrand |
|
Subject: |
Re: [PATCH v6 14/18] s390x: protvirt: Move IO control structures over SIDA |
|
Date: |
Wed, 4 Mar 2020 19:56:24 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
On 04.03.20 12:42, Janosch Frank wrote:
> For protected guests, we need to put the IO emulation results into the
> SIDA, so SIE will write them into the guest at the next entry.
>
[...]
>
> if (ioinst_disassemble_sch_ident(reg1, &m, &cssid, &ssid, &schid)) {
> + if (env->pv) {
> + return;
> + }
Can you elaborate why we don't have to do anything here? I can
understand why we don't/cannot probe for writes. But what about the
PGM_OPERAND?
[...]
Apart from that, looks good to me.
--
Thanks,
David / dhildenb
- Re: [PATCH v6 13/18] s390x: protvirt: Disable address checks for PV guest IO emulation, (continued)
[PATCH v6 11/18] s390x: protvirt: Set guest IPL PSW, Janosch Frank, 2020/03/04
[PATCH v6 09/18] s390x: protvirt: Move STSI data over SIDAD, Janosch Frank, 2020/03/04
[PATCH v6 14/18] s390x: protvirt: Move IO control structures over SIDA, Janosch Frank, 2020/03/04
- Re: [PATCH v6 14/18] s390x: protvirt: Move IO control structures over SIDA,
David Hildenbrand <=
[PATCH v6 12/18] s390x: protvirt: Move diag 308 data over SIDAD, Janosch Frank, 2020/03/04
[PATCH v6 16/18] s390x: Add unpack facility feature to GA1, Janosch Frank, 2020/03/04
[PATCH v6 17/18] docs: Add protvirt docs, Janosch Frank, 2020/03/04