Re: [PATCH v3 1/6] s390x: fix memleaks in cpu_finalize

[Pan Nengyuan]

On 3/2/2020 10:34 PM, Stefan Hajnoczi wrote:
> On Thu, Feb 27, 2020 at 2:42 AM Pan Nengyuan <address@hidden> wrote:
>>
>> This patch fix memleaks when we call tests/qtest/cpu-plug-test on s390x. The 
>> leak stack is as follow:
>>
>> Direct leak of 48 byte(s) in 1 object(s) allocated from:
>>     #0 0x7fb43c7cd970 in __interceptor_calloc (/lib64/libasan.so.5+0xef970)
>>     #1 0x7fb43be2149d in g_malloc0 (/lib64/libglib-2.0.so.0+0x5249d)
>>     #2 0x558ba96da716 in timer_new_full 
>> /mnt/sdb/qemu-new/qemu/include/qemu/timer.h:530
>>     #3 0x558ba96da716 in timer_new 
>> /mnt/sdb/qemu-new/qemu/include/qemu/timer.h:551
>>     #4 0x558ba96da716 in timer_new_ns 
>> /mnt/sdb/qemu-new/qemu/include/qemu/timer.h:569
>>     #5 0x558ba96da716 in s390_cpu_initfn 
>> /mnt/sdb/qemu-new/qemu/target/s390x/cpu.c:285
>>     #6 0x558ba9c969ab in object_init_with_type 
>> /mnt/sdb/qemu-new/qemu/qom/object.c:372
>>     #7 0x558ba9c9eb5f in object_initialize_with_type 
>> /mnt/sdb/qemu-new/qemu/qom/object.c:516
>>     #8 0x558ba9c9f053 in object_new_with_type 
>> /mnt/sdb/qemu-new/qemu/qom/object.c:684
>>     #9 0x558ba967ede6 in s390x_new_cpu 
>> /mnt/sdb/qemu-new/qemu/hw/s390x/s390-virtio-ccw.c:64
>>     #10 0x558ba99764b3 in hmp_cpu_add 
>> /mnt/sdb/qemu-new/qemu/hw/core/machine-hmp-cmds.c:57
>>     #11 0x558ba9b1c27f in handle_hmp_command 
>> /mnt/sdb/qemu-new/qemu/monitor/hmp.c:1082
>>     #12 0x558ba96c1b02 in qmp_human_monitor_command 
>> /mnt/sdb/qemu-new/qemu/monitor/misc.c:142
>>
>> Reported-by: Euler Robot <address@hidden>
>> Signed-off-by: Pan Nengyuan <address@hidden>
>> ---
>> Cc: Richard Henderson <address@hidden>
>> Cc: David Hildenbrand <address@hidden>
>> Cc: Cornelia Huck <address@hidden>
>> Cc: address@hidden
>> ---
>> v2->v1:
>> - Similarly to other cleanups, move timer_new into realize(Suggested by 
>> Philippe Mathieu-Daudé)
> 
> Hi,
> This email is invalid and cannot be parsed by the patches
> (https://github.com/stefanha/patches) tool that is used by some QEMU
> maintainers to apply patches.
> 
> The character set is incorrectly set to "base64", which is a content
> transfer encoding and not a character set:
> 
>   Content-Type: text/plain; charset="base64"
>   Content-Transfer-Encoding: quoted-printable
> 
> There is a UTF-8 é character here:
> 
>   - Similarly to other cleanups, move timer_new into realize(Suggested by Phi=
>   lippe Mathieu-Daud=C3=A9)
> 
> Since there is no valid charset the é character cannot be decoded.
> 
> This might be a mail server problem but it could also be due to your
> git-send-email(1) configuration.
> 
> Did you set the charset to "base64" or override the content transfer
> encoding?  I think other people on the list will have trouble
> receiving emails like this too.

Yes, it's set to "base64", I will correct it.

Thanks.

> 
> Stefan
> .
>