[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 06/18] s390x: protvirt: Handle diag 308 subcodes 0,1,3,4
From: |
Janosch Frank |
Subject: |
Re: [PATCH v5 06/18] s390x: protvirt: Handle diag 308 subcodes 0,1,3,4 |
Date: |
Wed, 26 Feb 2020 16:11:40 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 |
On 2/26/20 4:00 PM, Christian Borntraeger wrote:
>
>
> On 26.02.20 13:20, Janosch Frank wrote:
>> As we now have access to the protection state of the cpus, we can
>> implement special handling of diag 308 subcodes for cpus in the
>> protected state.
>>
>> For subcodes 0 and 1 we need to unshare all pages before continuing,
>> so the guest doesn't accidentally expose data when dumping.
>>
>> For subcode 3/4 we tear down the protected VM and reboot into
>> unprotected mode. We do not provide a secure reboot.
>>
>> Before we can do the unshare calls, we need to mark all cpus as
>> stopped.
>>
>> Signed-off-by: Janosch Frank <address@hidden>
>> ---
>> hw/s390x/s390-virtio-ccw.c | 37 ++++++++++++++++++++++++++++++++++---
>> target/s390x/diag.c | 4 ++++
>> 2 files changed, 38 insertions(+), 3 deletions(-)
>>
>> diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c
>> index 79f472c309..9983165b05 100644
>> --- a/hw/s390x/s390-virtio-ccw.c
>> +++ b/hw/s390x/s390-virtio-ccw.c
>> @@ -335,6 +335,7 @@ static void s390_machine_unprotect(S390CcwMachineState
>> *ms)
>> }
>> ms->pv = false;
>> }
>> + migrate_del_blocker(pv_mig_blocker);
>> }
>>
>
> and that part into patch 5?
>
>
Already fixed in the branch :-)
signature.asc
Description: OpenPGP digital signature
- Re: [PATCH v5 01/18] s390x: Use constant for ESA PSW address, (continued)
- Re: [PATCH v5 01/18] s390x: Use constant for ESA PSW address, Janosch Frank, 2020/02/27
- Re: [PATCH v5 01/18] s390x: Use constant for ESA PSW address, Cornelia Huck, 2020/02/27
- [PATCH v6] s390x: Rename and use constants for short PSW address and mask, Janosch Frank, 2020/02/27
- Re: [PATCH v6] s390x: Rename and use constants for short PSW address and mask, David Hildenbrand, 2020/02/27
- Re: [PATCH v6] s390x: Rename and use constants for short PSW address and mask, Cornelia Huck, 2020/02/27
[PATCH v5 05/18] s390x: protvirt: Add migration blocker, Janosch Frank, 2020/02/26
[PATCH v5 06/18] s390x: protvirt: Handle diag 308 subcodes 0,1,3,4, Janosch Frank, 2020/02/26
[PATCH v5 04/18] s390x: protvirt: Support unpack facility, Janosch Frank, 2020/02/26
[PATCH v5 07/18] s390x: protvirt: Inhibit balloon when switching to protected mode, Janosch Frank, 2020/02/26
- Re: [PATCH v5 07/18] s390x: protvirt: Inhibit balloon when switching to protected mode, David Hildenbrand, 2020/02/26
- Re: [PATCH v5 07/18] s390x: protvirt: Inhibit balloon when switching to protected mode, Christian Borntraeger, 2020/02/26
- Re: [PATCH v5 07/18] s390x: protvirt: Inhibit balloon when switching to protected mode, David Hildenbrand, 2020/02/26
- Re: [PATCH v5 07/18] s390x: protvirt: Inhibit balloon when switching to protected mode, Janosch Frank, 2020/02/26
- Re: [PATCH v5 07/18] s390x: protvirt: Inhibit balloon when switching to protected mode, David Hildenbrand, 2020/02/26
- Re: [PATCH v5 07/18] s390x: protvirt: Inhibit balloon when switching to protected mode, Cornelia Huck, 2020/02/26
Re: [PATCH v5 07/18] s390x: protvirt: Inhibit balloon when switching to protected mode, Janosch Frank, 2020/02/26
Re: [PATCH v5 07/18] s390x: protvirt: Inhibit balloon when switching to protected mode, Christian Borntraeger, 2020/02/26