[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 09/15] target/s390x: Move struct DisasFields definition earlier
From: |
Cornelia Huck |
Subject: |
[PULL 09/15] target/s390x: Move struct DisasFields definition earlier |
Date: |
Mon, 27 Jan 2020 13:20:10 +0100 |
From: Richard Henderson <address@hidden>
We will want to include the struct in DisasContext.
Signed-off-by: Richard Henderson <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
Signed-off-by: Cornelia Huck <address@hidden>
---
target/s390x/translate.c | 164 ++++++++++++++++++++-------------------
1 file changed, 83 insertions(+), 81 deletions(-)
diff --git a/target/s390x/translate.c b/target/s390x/translate.c
index b764ec3140ff..7ef228843aa4 100644
--- a/target/s390x/translate.c
+++ b/target/s390x/translate.c
@@ -53,6 +53,89 @@ typedef struct DisasContext DisasContext;
typedef struct DisasInsn DisasInsn;
typedef struct DisasFields DisasFields;
+/*
+ * Define a structure to hold the decoded fields. We'll store each inside
+ * an array indexed by an enum. In order to conserve memory, we'll arrange
+ * for fields that do not exist at the same time to overlap, thus the "C"
+ * for compact. For checking purposes there is an "O" for original index
+ * as well that will be applied to availability bitmaps.
+ */
+
+enum DisasFieldIndexO {
+ FLD_O_r1,
+ FLD_O_r2,
+ FLD_O_r3,
+ FLD_O_m1,
+ FLD_O_m3,
+ FLD_O_m4,
+ FLD_O_m5,
+ FLD_O_m6,
+ FLD_O_b1,
+ FLD_O_b2,
+ FLD_O_b4,
+ FLD_O_d1,
+ FLD_O_d2,
+ FLD_O_d4,
+ FLD_O_x2,
+ FLD_O_l1,
+ FLD_O_l2,
+ FLD_O_i1,
+ FLD_O_i2,
+ FLD_O_i3,
+ FLD_O_i4,
+ FLD_O_i5,
+ FLD_O_v1,
+ FLD_O_v2,
+ FLD_O_v3,
+ FLD_O_v4,
+};
+
+enum DisasFieldIndexC {
+ FLD_C_r1 = 0,
+ FLD_C_m1 = 0,
+ FLD_C_b1 = 0,
+ FLD_C_i1 = 0,
+ FLD_C_v1 = 0,
+
+ FLD_C_r2 = 1,
+ FLD_C_b2 = 1,
+ FLD_C_i2 = 1,
+
+ FLD_C_r3 = 2,
+ FLD_C_m3 = 2,
+ FLD_C_i3 = 2,
+ FLD_C_v3 = 2,
+
+ FLD_C_m4 = 3,
+ FLD_C_b4 = 3,
+ FLD_C_i4 = 3,
+ FLD_C_l1 = 3,
+ FLD_C_v4 = 3,
+
+ FLD_C_i5 = 4,
+ FLD_C_d1 = 4,
+ FLD_C_m5 = 4,
+
+ FLD_C_d2 = 5,
+ FLD_C_m6 = 5,
+
+ FLD_C_d4 = 6,
+ FLD_C_x2 = 6,
+ FLD_C_l2 = 6,
+ FLD_C_v2 = 6,
+
+ NUM_C_FIELD = 7
+};
+
+struct DisasFields {
+ uint64_t raw_insn;
+ unsigned op:8;
+ unsigned op2:8;
+ unsigned presentC:16;
+ unsigned int presentO;
+ int c[NUM_C_FIELD];
+};
+
struct DisasContext {
DisasContextBase base;
const DisasInsn *insn;
@@ -1005,87 +1088,6 @@ typedef enum {
#undef F5
#undef F6
-/* Define a structure to hold the decoded fields. We'll store each inside
- an array indexed by an enum. In order to conserve memory, we'll arrange
- for fields that do not exist at the same time to overlap, thus the "C"
- for compact. For checking purposes there is an "O" for original index
- as well that will be applied to availability bitmaps. */
-
-enum DisasFieldIndexO {
- FLD_O_r1,
- FLD_O_r2,
- FLD_O_r3,
- FLD_O_m1,
- FLD_O_m3,
- FLD_O_m4,
- FLD_O_m5,
- FLD_O_m6,
- FLD_O_b1,
- FLD_O_b2,
- FLD_O_b4,
- FLD_O_d1,
- FLD_O_d2,
- FLD_O_d4,
- FLD_O_x2,
- FLD_O_l1,
- FLD_O_l2,
- FLD_O_i1,
- FLD_O_i2,
- FLD_O_i3,
- FLD_O_i4,
- FLD_O_i5,
- FLD_O_v1,
- FLD_O_v2,
- FLD_O_v3,
- FLD_O_v4,
-};
-
-enum DisasFieldIndexC {
- FLD_C_r1 = 0,
- FLD_C_m1 = 0,
- FLD_C_b1 = 0,
- FLD_C_i1 = 0,
- FLD_C_v1 = 0,
-
- FLD_C_r2 = 1,
- FLD_C_b2 = 1,
- FLD_C_i2 = 1,
-
- FLD_C_r3 = 2,
- FLD_C_m3 = 2,
- FLD_C_i3 = 2,
- FLD_C_v3 = 2,
-
- FLD_C_m4 = 3,
- FLD_C_b4 = 3,
- FLD_C_i4 = 3,
- FLD_C_l1 = 3,
- FLD_C_v4 = 3,
-
- FLD_C_i5 = 4,
- FLD_C_d1 = 4,
- FLD_C_m5 = 4,
-
- FLD_C_d2 = 5,
- FLD_C_m6 = 5,
-
- FLD_C_d4 = 6,
- FLD_C_x2 = 6,
- FLD_C_l2 = 6,
- FLD_C_v2 = 6,
-
- NUM_C_FIELD = 7
-};
-
-struct DisasFields {
- uint64_t raw_insn;
- unsigned op:8;
- unsigned op2:8;
- unsigned presentC:16;
- unsigned int presentO;
- int c[NUM_C_FIELD];
-};
-
/* This is the way fields are to be accessed out of DisasFields. */
#define have_field(S, F) have_field1((S), FLD_O_##F)
#define get_field(S, F) get_field1((S), FLD_O_##F, FLD_C_##F)
--
2.21.1
- [PULL 00/15] s390x update, Cornelia Huck, 2020/01/27
- [PULL 01/15] s390x/sclp.c: remove unneeded label in sclp_service_call(), Cornelia Huck, 2020/01/27
- [PULL 02/15] intc/s390_flic_kvm.c: remove unneeded label in kvm_flic_load(), Cornelia Huck, 2020/01/27
- [PULL 03/15] s390x/event-facility.c: remove unneeded labels, Cornelia Huck, 2020/01/27
- [PULL 04/15] s390x: adapter routes error handling, Cornelia Huck, 2020/01/27
- [PULL 05/15] s390x/event-facility: fix error propagation, Cornelia Huck, 2020/01/27
- [PULL 06/15] target/s390x: Remove duplicated ifdef macro, Cornelia Huck, 2020/01/27
- [PULL 07/15] docs/devel: fix stable process doc formatting, Cornelia Huck, 2020/01/27
- [PULL 09/15] target/s390x: Move struct DisasFields definition earlier,
Cornelia Huck <=
- [PULL 08/15] target/s390x/kvm: Enable adapter interruption suppression again, Cornelia Huck, 2020/01/27
- [PULL 10/15] target/s390x: Remove DisasFields argument from callbacks, Cornelia Huck, 2020/01/27
- [PULL 12/15] target/s390x: Move DisasFields into DisasContext, Cornelia Huck, 2020/01/27
- [PULL 14/15] hw/s390x: Add a more verbose comment about get_machine_class() and the wrappers, Cornelia Huck, 2020/01/27
- [PULL 13/15] target/s390x: Remove DisasFields argument from extract_insn, Cornelia Huck, 2020/01/27
- [PULL 15/15] s390x: sigp: Fix sense running reporting, Cornelia Huck, 2020/01/27
- [PULL 11/15] target/s390x: Pass DisasContext to get_field and have_field, Cornelia Huck, 2020/01/27
- Re: [PULL 00/15] s390x update, Peter Maydell, 2020/01/27