Re: [PATCH] s390x: sigp: Fix sense running reporting

[Cornelia Huck]

On Fri, 24 Jan 2020 05:01:37 -0500
Janosch Frank <address@hidden> wrote:

> The logic was inversed and reported running if the cpu was stopped.

s/inversed/inverted/ ?

> Let's fix that.
>

Fixes: d1b468bc8869 ("s390x/tcg: implement SIGP SENSE RUNNING STATUS")

> Signed-off-by: Janosch Frank <address@hidden>
> ---
>  target/s390x/sigp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/target/s390x/sigp.c b/target/s390x/sigp.c
> index 727875bb4a..286c0d6c9c 100644
> --- a/target/s390x/sigp.c
> +++ b/target/s390x/sigp.c
> @@ -347,7 +347,7 @@ static void sigp_sense_running(S390CPU *dst_cpu, SigpInfo 
> *si)
>      }
>  
>      /* If halted (which includes also STOPPED), it is not running */
> -    if (CPU(dst_cpu)->halted) {
> +    if (!CPU(dst_cpu)->halted) {
>          si->cc = SIGP_CC_ORDER_CODE_ACCEPTED;
>      } else {
>          set_sigp_status(si, SIGP_STAT_NOT_RUNNING);

I'm wondering why nobody noticed this before...