[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] s390x/event-facility: fix error propagation
From: |
Cornelia Huck |
Subject: |
[PATCH] s390x/event-facility: fix error propagation |
Date: |
Tue, 21 Jan 2020 10:55:06 +0100 |
We currently check (by error) if the passed-in Error pointer errp
is non-null and return after realizing the first child of the
event facility in that case. Symptom is that 'virsh shutdown'
does not work, as the sclpquiesce device is not realized.
Fix this by (correctly) checking the local Error err.
Reported-by: Christian Borntraeger <address@hidden>
Fixes: 3d508334dd2c ("s390x/event-facility: Fix realize() error API violations")
Signed-off-by: Cornelia Huck <address@hidden>
---
hw/s390x/event-facility.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/s390x/event-facility.c b/hw/s390x/event-facility.c
index 8a93b8a1da97..9d6972afa8b3 100644
--- a/hw/s390x/event-facility.c
+++ b/hw/s390x/event-facility.c
@@ -338,7 +338,7 @@ static void sclp_events_bus_realize(BusState *bus, Error
**errp)
DeviceState *dev = kid->child;
object_property_set_bool(OBJECT(dev), true, "realized", &err);
- if (errp) {
+ if (err) {
error_propagate(errp, err);
return;
}
--
2.21.1
- [PATCH] s390x/event-facility: fix error propagation,
Cornelia Huck <=
- Re: [PATCH] s390x/event-facility: fix error propagation, David Hildenbrand, 2020/01/21
- Re: [PATCH] s390x/event-facility: fix error propagation, Christian Borntraeger, 2020/01/21
- Re: [PATCH] s390x/event-facility: fix error propagation, Thomas Huth, 2020/01/21
- Re: [PATCH] s390x/event-facility: fix error propagation, Markus Armbruster, 2020/01/21
- Re: [PATCH] s390x/event-facility: fix error propagation, Cornelia Huck, 2020/01/21