[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 06/11] hw/core/qdev: handle parent bus change regarding re
From: |
Richard Henderson |
Subject: |
Re: [PATCH v6 06/11] hw/core/qdev: handle parent bus change regarding resettable |
Date: |
Sun, 29 Dec 2019 10:51:03 +1100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 |
On 12/20/19 10:50 PM, Damien Hedde wrote:
> In qdev_set_parent_bus(), when changing the parent bus of a
> realized device, if the source and destination buses are not in the
> same reset state, some adaptations are required. This patch adds
> needed call to resettable_change_parent() to make sure a device reset
> state stays coherent with its parent bus.
>
> The addition is a no-op if:
> 1. the device being parented is not realized.
> 2. the device is realized, but both buses are not under reset.
>
> Case 2 means that as long as qdev_set_parent_bus() is called
> during the machine realization procedure (which is before the
> machine reset so nothing is in reset), it is a no op.
Reviewed-by: Richard Henderson <address@hidden>
r~
- [PATCH v6 00/11] Multi-phase reset mechanism, Damien Hedde, 2019/12/20
- [PATCH v6 02/11] hw/core/qdev: add trace events to help with resettable transition, Damien Hedde, 2019/12/20
- [PATCH v6 08/11] hw/core: deprecate old reset functions and introduce new ones, Damien Hedde, 2019/12/20
- [PATCH v6 06/11] hw/core/qdev: handle parent bus change regarding resettable, Damien Hedde, 2019/12/20
- Re: [PATCH v6 06/11] hw/core/qdev: handle parent bus change regarding resettable,
Richard Henderson <=
- [PATCH v6 01/11] add device_legacy_reset function to prepare for reset api change, Damien Hedde, 2019/12/20
- [PATCH v6 04/11] hw/core: add Resettable support to BusClass and DeviceClass, Damien Hedde, 2019/12/20
- [PATCH v6 07/11] hw/core/qdev: update hotplug reset regarding resettable, Damien Hedde, 2019/12/20
- [PATCH v6 05/11] hw/core/resettable: add support for changing parent, Damien Hedde, 2019/12/20
- [PATCH v6 10/11] vl: replace deprecated qbus_reset_all registration, Damien Hedde, 2019/12/20
- [PATCH v6 03/11] hw/core: create Resettable QOM interface, Damien Hedde, 2019/12/20