[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[RFC PATCH 13/14] hw/char/terminal3270: Explicit ignored QEMUChrEvent in
From: |
Philippe Mathieu-Daudé |
Subject: |
[RFC PATCH 13/14] hw/char/terminal3270: Explicit ignored QEMUChrEvent in IOEventHandler |
Date: |
Tue, 17 Dec 2019 17:38:07 +0100 |
The Chardev events are listed in the QEMUChrEvent enum. To be
able to use this enum in the IOEventHandler typedef, we need to
explicit when frontends ignore some events, to silent GCC the
following warnings:
CC s390x-softmmu/hw/char/terminal3270.o
hw/char/terminal3270.c: In function ‘chr_event’:
hw/char/terminal3270.c:156:5: error: enumeration value ‘CHR_EVENT_BREAK’ not
handled in switch [-Werror=switch]
156 | switch (event) {
| ^~~~~~
hw/char/terminal3270.c:156:5: error: enumeration value ‘CHR_EVENT_MUX_IN’ not
handled in switch [-Werror=switch]
hw/char/terminal3270.c:156:5: error: enumeration value ‘CHR_EVENT_MUX_OUT’
not handled in switch [-Werror=switch]
cc1: all warnings being treated as errors
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
---
Cc: Cornelia Huck <address@hidden>
Cc: Halil Pasic <address@hidden>
Cc: Christian Borntraeger <address@hidden>
Cc: "Marc-André Lureau" <address@hidden>
Cc: Paolo Bonzini <address@hidden>
Cc: address@hidden
---
hw/char/terminal3270.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/hw/char/terminal3270.c b/hw/char/terminal3270.c
index 6859c1bcb2..9e59a2d92b 100644
--- a/hw/char/terminal3270.c
+++ b/hw/char/terminal3270.c
@@ -166,6 +166,9 @@ static void chr_event(void *opaque, int event)
sch->curr_status.scsw.dstat = SCSW_DSTAT_DEVICE_END;
css_conditional_io_interrupt(sch);
break;
+ default:
+ /* Ignore */
+ break;
}
}
--
2.21.0
- [RFC PATCH 03/14] vhost-user: Explicit we ignore some QEMUChrEvent in IOEventHandler, (continued)
- [RFC PATCH 03/14] vhost-user: Explicit we ignore some QEMUChrEvent in IOEventHandler, Philippe Mathieu-Daudé, 2019/12/17
- [RFC PATCH 04/14] virtio-console: Explicit we ignore some QEMUChrEvent in IOEventHandler, Philippe Mathieu-Daudé, 2019/12/17
- [RFC PATCH 05/14] hw/ipmi: Explicit we ignore some QEMUChrEvent in IOEventHandler, Philippe Mathieu-Daudé, 2019/12/17
- [RFC PATCH 06/14] hw/usb/dev-serial: Explicit we ignore few QEMUChrEvent in IOEventHandler, Philippe Mathieu-Daudé, 2019/12/17
- [RFC PATCH 07/14] ccid-card-passthru: Explicit we ignore QEMUChrEvent in IOEventHandler, Philippe Mathieu-Daudé, 2019/12/17
- [RFC PATCH 08/14] hw/usb/redirect: Explicit we ignore few QEMUChrEvent in IOEventHandler, Philippe Mathieu-Daudé, 2019/12/17
- [RFC PATCH 09/14] monitor/qmp: Explicit we ignore few QEMUChrEvent in IOEventHandler, Philippe Mathieu-Daudé, 2019/12/17
- [RFC PATCH 10/14] monitor/hmp: Explicit we ignore a QEMUChrEvent in IOEventHandler, Philippe Mathieu-Daudé, 2019/12/17
- [RFC PATCH 11/14] net/vhost-user: Explicit we ignore few QEMUChrEvent in IOEventHandler, Philippe Mathieu-Daudé, 2019/12/17
- [RFC PATCH 12/14] vhost-user-blk: Explicit we ignore few QEMUChrEvent in IOEventHandler, Philippe Mathieu-Daudé, 2019/12/17
- [RFC PATCH 13/14] hw/char/terminal3270: Explicit ignored QEMUChrEvent in IOEventHandler,
Philippe Mathieu-Daudé <=
- [PATCH 14/14] chardev: Use QEMUChrEvent enum in IOEventHandler typedef, Philippe Mathieu-Daudé, 2019/12/17
- Re: [PATCH 00/14] chardev: Use QEMUChrEvent enum in IOEventHandler typedef, Philippe Mathieu-Daudé, 2019/12/17