[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[RFC PATCH 02/14] chardev/char: Explicit we ignore some QEMUChrEvent in
From: |
Philippe Mathieu-Daudé |
Subject: |
[RFC PATCH 02/14] chardev/char: Explicit we ignore some QEMUChrEvent in IOEventHandler |
Date: |
Tue, 17 Dec 2019 17:37:56 +0100 |
The Chardev events are listed in the QEMUChrEvent enum. To be
able to use this enum in the IOEventHandler typedef, we need to
explicit when frontends ignore some events, to silent GCC the
following warnings:
chardev/char.c: In function ‘qemu_chr_be_event’:
chardev/char.c:65:5: error: enumeration value ‘CHR_EVENT_BREAK’ not handled
in switch [-Werror=switch]
65 | switch (event) {
| ^~~~~~
chardev/char.c:65:5: error: enumeration value ‘CHR_EVENT_MUX_IN’ not handled
in switch [-Werror=switch]
chardev/char.c:65:5: error: enumeration value ‘CHR_EVENT_MUX_OUT’ not handled
in switch [-Werror=switch]
cc1: all warnings being treated as errors
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
---
Cc: "Marc-André Lureau" <address@hidden>
Cc: Paolo Bonzini <address@hidden>
---
chardev/char.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/chardev/char.c b/chardev/char.c
index 7b6b2cb123..c4b6bbc55a 100644
--- a/chardev/char.c
+++ b/chardev/char.c
@@ -69,6 +69,9 @@ void qemu_chr_be_event(Chardev *s, int event)
case CHR_EVENT_CLOSED:
s->be_open = 0;
break;
+ default:
+ /* Ignore */
+ break;
}
CHARDEV_GET_CLASS(s)->chr_be_event(s, event);
--
2.21.0
- [PATCH 00/14] chardev: Use QEMUChrEvent enum in IOEventHandler typedef, Philippe Mathieu-Daudé, 2019/12/17
- [PATCH 01/14] hw/ipmi: Remove unnecessary declarations, Philippe Mathieu-Daudé, 2019/12/17
- [RFC PATCH 02/14] chardev/char: Explicit we ignore some QEMUChrEvent in IOEventHandler,
Philippe Mathieu-Daudé <=
- [RFC PATCH 03/14] vhost-user: Explicit we ignore some QEMUChrEvent in IOEventHandler, Philippe Mathieu-Daudé, 2019/12/17
- [RFC PATCH 04/14] virtio-console: Explicit we ignore some QEMUChrEvent in IOEventHandler, Philippe Mathieu-Daudé, 2019/12/17
- [RFC PATCH 05/14] hw/ipmi: Explicit we ignore some QEMUChrEvent in IOEventHandler, Philippe Mathieu-Daudé, 2019/12/17
- [RFC PATCH 06/14] hw/usb/dev-serial: Explicit we ignore few QEMUChrEvent in IOEventHandler, Philippe Mathieu-Daudé, 2019/12/17
- [RFC PATCH 07/14] ccid-card-passthru: Explicit we ignore QEMUChrEvent in IOEventHandler, Philippe Mathieu-Daudé, 2019/12/17
- [RFC PATCH 08/14] hw/usb/redirect: Explicit we ignore few QEMUChrEvent in IOEventHandler, Philippe Mathieu-Daudé, 2019/12/17
- [RFC PATCH 09/14] monitor/qmp: Explicit we ignore few QEMUChrEvent in IOEventHandler, Philippe Mathieu-Daudé, 2019/12/17
- [RFC PATCH 10/14] monitor/hmp: Explicit we ignore a QEMUChrEvent in IOEventHandler, Philippe Mathieu-Daudé, 2019/12/17
- [RFC PATCH 11/14] net/vhost-user: Explicit we ignore few QEMUChrEvent in IOEventHandler, Philippe Mathieu-Daudé, 2019/12/17
- [RFC PATCH 12/14] vhost-user-blk: Explicit we ignore few QEMUChrEvent in IOEventHandler, Philippe Mathieu-Daudé, 2019/12/17