[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 2/9] s390x/mmu: Remove duplicate check for MMU_DATA_STORE
From: |
Cornelia Huck |
Subject: |
[PULL 2/9] s390x/mmu: Remove duplicate check for MMU_DATA_STORE |
Date: |
Tue, 22 Oct 2019 11:54:21 +0200 |
From: David Hildenbrand <address@hidden>
No need to double-check if we have a write.
Found by Coverity (CID: 1406404).
Fixes: 31b59419069e ("target/s390x: Return exception from mmu_translate_real")
Cc: Peter Maydell <address@hidden>
Signed-off-by: David Hildenbrand <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Signed-off-by: Cornelia Huck <address@hidden>
---
target/s390x/mmu_helper.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/target/s390x/mmu_helper.c b/target/s390x/mmu_helper.c
index 90b81335f920..c9f3f3475010 100644
--- a/target/s390x/mmu_helper.c
+++ b/target/s390x/mmu_helper.c
@@ -556,9 +556,7 @@ int mmu_translate_real(CPUS390XState *env, target_ulong
raddr, int rw,
*flags |= PAGE_WRITE_INV;
if (is_low_address(raddr) && rw == MMU_DATA_STORE) {
/* LAP sets bit 56 */
- *tec = (raddr & TARGET_PAGE_MASK)
- | (rw == MMU_DATA_STORE ? FS_WRITE : FS_READ)
- | 0x80;
+ *tec = (raddr & TARGET_PAGE_MASK) | FS_WRITE | 0x80;
return PGM_PROTECTION;
}
}
--
2.21.0
- [PULL 0/9] more s390x fixes, Cornelia Huck, 2019/10/22
- [PULL 1/9] s390x/cpumodel: Add missing visit_free, Cornelia Huck, 2019/10/22
- [PULL 2/9] s390x/mmu: Remove duplicate check for MMU_DATA_STORE,
Cornelia Huck <=
- [PULL 3/9] s390x/tcg: Fix VECTOR MULTIPLY LOGICAL ODD, Cornelia Huck, 2019/10/22
- [PULL 4/9] s390x/tcg: Fix VECTOR MULTIPLY AND ADD *, Cornelia Huck, 2019/10/22
- [PULL 5/9] s390x/tcg: Fix VECTOR SHIFT RIGHT ARITHMETIC BY BYTE, Cornelia Huck, 2019/10/22
- [PULL 6/9] s390x/tcg: Fix VECTOR SUBTRACT COMPUTE BORROW INDICATION, Cornelia Huck, 2019/10/22
- [PULL 7/9] s390x/tcg: Fix VECTOR SUBTRACT WITH BORROW INDICATION, Cornelia Huck, 2019/10/22
- [PULL 8/9] s390x/tcg: Fix VECTOR SUBTRACT WITH BORROW COMPUTE BORROW INDICATION, Cornelia Huck, 2019/10/22
- [PULL 9/9] s390x/kvm: Set default cpu model for all machine classes, Cornelia Huck, 2019/10/22
- Re: [PULL 0/9] more s390x fixes, Peter Maydell, 2019/10/22