[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1] s390x/kvm: Set default cpu model for all machine classes
|
From: |
Cornelia Huck |
|
Subject: |
Re: [PATCH v1] s390x/kvm: Set default cpu model for all machine classes |
|
Date: |
Mon, 21 Oct 2019 12:01:25 +0200 |
On Mon, 21 Oct 2019 11:58:35 +0200
David Hildenbrand <address@hidden> wrote:
> > query-machines probes with the "none" machine all other machines.
> > Current code only fixes up the active machine.
> >
>
> To be more precise, libvirt probes with "-machine none,accel=kvm:tcg"
> all other machines.
Add that to the patch description?
>
> > (that's why you won't notice when starting a machine - you will always
> > get "host" for the active one)
> >
> >>
> >> Anyway, your patch sounds fine, so (with "klass" replaced by "oc"):
Respin with that? Makes it easier to pick up :)
> >>
> >> Reviewed-by: Thomas Huth <address@hidden>
> >>
> >
> >
>
>