[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 18/20] hw/i386: Include "hw/mem/nvdimm.h"
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH 18/20] hw/i386: Include "hw/mem/nvdimm.h" |
Date: |
Mon, 14 Oct 2019 16:22:44 +0200 |
All this files use methods/definitions declared in the NVDIMM
device header. Include it.
This fixes (when modifying unrelated headers):
hw/i386/acpi-build.c:2733:9: error: implicit declaration of function
'nvdimm_build_acpi' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
nvdimm_build_acpi(table_offsets, tables_blob, tables->linker,
^
hw/i386/pc.c:1996:61: error: use of undeclared identifier 'TYPE_NVDIMM'
const bool is_nvdimm = object_dynamic_cast(OBJECT(dev), TYPE_NVDIMM);
^
hw/i386/pc.c:2032:55: error: use of undeclared identifier 'TYPE_NVDIMM'
bool is_nvdimm = object_dynamic_cast(OBJECT(dev), TYPE_NVDIMM);
^
hw/i386/pc.c:2040:9: error: implicit declaration of function 'nvdimm_plug' is
invalid in C99 [-Werror,-Wimplicit-function-declaration]
nvdimm_plug(ms->nvdimms_state);
^
hw/i386/pc.c:2040:9: error: this function declaration is not a prototype
[-Werror,-Wstrict-prototypes]
nvdimm_plug(ms->nvdimms_state);
^
hw/i386/pc.c:2065:42: error: use of undeclared identifier 'TYPE_NVDIMM'
if (object_dynamic_cast(OBJECT(dev), TYPE_NVDIMM)) {
^
hw/i386/pc_i440fx.c:307:9: error: implicit declaration of function
'nvdimm_init_acpi_state' is invalid in C99
[-Werror,-Wimplicit-function-declaration]
nvdimm_init_acpi_state(machine->nvdimms_state, system_io,
^
hw/i386/pc_q35.c:332:9: error: implicit declaration of function
'nvdimm_init_acpi_state' is invalid in C99
[-Werror,-Wimplicit-function-declaration]
nvdimm_init_acpi_state(machine->nvdimms_state, system_io,
^
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
---
hw/i386/acpi-build.c | 1 +
hw/i386/pc.c | 1 +
hw/i386/pc_piix.c | 1 +
hw/i386/pc_q35.c | 1 +
4 files changed, 4 insertions(+)
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
index 4e0f9f425a..ac46936f63 100644
--- a/hw/i386/acpi-build.c
+++ b/hw/i386/acpi-build.c
@@ -48,6 +48,7 @@
#include "hw/timer/mc146818rtc_regs.h"
#include "migration/vmstate.h"
#include "hw/mem/memory-device.h"
+#include "hw/mem/nvdimm.h"
#include "sysemu/numa.h"
#include "sysemu/reset.h"
diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index bcda50efcc..cff330802d 100644
--- a/hw/i386/pc.c
+++ b/hw/i386/pc.c
@@ -73,6 +73,7 @@
#include "hw/boards.h"
#include "acpi-build.h"
#include "hw/mem/pc-dimm.h"
+#include "hw/mem/nvdimm.h"
#include "qapi/error.h"
#include "qapi/qapi-visit-common.h"
#include "qapi/visitor.h"
diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
index 6824b72124..8651b6e2ec 100644
--- a/hw/i386/pc_piix.c
+++ b/hw/i386/pc_piix.c
@@ -58,6 +58,7 @@
#include "migration/misc.h"
#include "kvm_i386.h"
#include "sysemu/numa.h"
+#include "hw/mem/nvdimm.h"
#define MAX_IDE_BUS 2
diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c
index 8fad20f314..91ba231ef1 100644
--- a/hw/i386/pc_q35.c
+++ b/hw/i386/pc_q35.c
@@ -53,6 +53,7 @@
#include "qapi/error.h"
#include "qemu/error-report.h"
#include "sysemu/numa.h"
+#include "hw/mem/nvdimm.h"
/* ICH9 AHCI has 6 ports */
#define MAX_SATA_PORTS 6
--
2.21.0
- Re: [PATCH 08/20] hw/xen/xen_pt_load_rom: Remove unused includes, (continued)
- [PATCH 09/20] hw/alpha/alpha_sys: Remove unused "hw/ide.h" header, Philippe Mathieu-Daudé, 2019/10/14
- [PATCH 10/20] hw/alpha/dp264: Include "net/net.h", Philippe Mathieu-Daudé, 2019/10/14
- [PATCH 11/20] hw/hppa/machine: Include "net/net.h", Philippe Mathieu-Daudé, 2019/10/14
- [PATCH 12/20] hw/acpi/cpu_hotplug: Include "hw/pci/pci.h", Philippe Mathieu-Daudé, 2019/10/14
- [PATCH 13/20] hw/timer/hpet: Include "exec/address-spaces.h", Philippe Mathieu-Daudé, 2019/10/14
- [PATCH 14/20] hw/pci-host/q35: Include "qemu/range.h", Philippe Mathieu-Daudé, 2019/10/14
- [PATCH 15/20] hw/i2c/smbus_ich9: Include "qemu/range.h", Philippe Mathieu-Daudé, 2019/10/14
- [PATCH 16/20] hw/pci-host/piix: Include "qemu/range.h", Philippe Mathieu-Daudé, 2019/10/14
- [PATCH 17/20] hw/acpi: Include "hw/mem/nvdimm.h", Philippe Mathieu-Daudé, 2019/10/14
- [PATCH 18/20] hw/i386: Include "hw/mem/nvdimm.h",
Philippe Mathieu-Daudé <=
- [PATCH 19/20] hw/pci-host/q35: Remove unused includes, Philippe Mathieu-Daudé, 2019/10/14
- [PATCH 20/20] hw/i386/pc: Clean up includes, Philippe Mathieu-Daudé, 2019/10/14
- Re: [PATCH 00/20] hw: Clean up hw/i386 headers (and few alpha/hppa), John Snow, 2019/10/14
- Re: [PATCH 00/20] hw: Clean up hw/i386 headers (and few alpha/hppa), Philippe Mathieu-Daudé, 2019/10/26