Re: [RFC v5 025/126] scripts: add coccinelle script to use auto propagated errp

[Eric Blake]

On 10/11/19 12:12 PM, Eric Blake wrote:
> On 10/11/19 11:04 AM, Vladimir Sementsov-Ogievskiy wrote:
> > Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> > ---

> > +@@
> > +identifier rule1.fn;
> > +identifier rule1.local_err;
> > +@@
> > +
> > + fn(...)
> > + {
> > +     <...
> > +(
> > +-    error_free(local_err);
> > +-    local_err = NULL;
> > ++    error_free_errp(errp);
>
> This does not make sense - error_free_errp() is not defined prior to 
> this series or anywhere in patches 1-24, if I'm reading it correctly.

Apologies - I sent my reply to this message before 21/126 showed up in 
my inbox, and didn't realize that I had skipped over sequencing.  This 
part is fine after all, but it points to the perils of reviewing a 
thread as it comes in piecemeal, vs. reviewing an actual branch with all 
patches instantly available.

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org