[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 05/25] scripts: add coccinelle script to fix error_append_
|
From: |
Eric Blake |
|
Subject: |
Re: [PATCH v3 05/25] scripts: add coccinelle script to fix error_append_hint usage |
|
Date: |
Tue, 24 Sep 2019 15:52:00 -0500 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
On 9/24/19 3:08 PM, Vladimir Sementsov-Ogievskiy wrote:
> error_append_hint will not work, if errp == &fatal_error, as program
> will exit before error_append_hint call. Fix this by use of special
> macro ERRP_FUNCTION_BEGIN.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> ---
> .../fix-error_append_hint-usage.cocci | 25 +++++++++++++++++++
> 1 file changed, 25 insertions(+)
> create mode 100644 scripts/coccinelle/fix-error_append_hint-usage.cocci
>
> +}
> +
>
Why are you creating a file with a trailing blank line?
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
Re: [PATCH v3 00/25] error: auto propagated local_err, no-reply, 2019/09/25