[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[qemu-s390x] [PULL SUBSYSTEM s390x 12/29] s390x/tcg: MVCS/MVCP: Properly
From: |
David Hildenbrand |
Subject: |
[qemu-s390x] [PULL SUBSYSTEM s390x 12/29] s390x/tcg: MVCS/MVCP: Properly wrap the length |
Date: |
Wed, 18 Sep 2019 17:29:05 +0200 |
... and don't perform any move in case the length is zero.
Reviewed-by: Richard Henderson <address@hidden>
Signed-off-by: David Hildenbrand <address@hidden>
---
target/s390x/mem_helper.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c
index 320e9ee65c..41d7336a1a 100644
--- a/target/s390x/mem_helper.c
+++ b/target/s390x/mem_helper.c
@@ -1980,10 +1980,13 @@ uint32_t HELPER(mvcs)(CPUS390XState *env, uint64_t l,
uint64_t a1, uint64_t a2)
s390_program_interrupt(env, PGM_SPECIAL_OP, ILEN_AUTO, ra);
}
+ l = wrap_length32(env, l);
if (l > 256) {
/* max 256 */
l = 256;
cc = 3;
+ } else if (!l) {
+ return cc;
}
/* XXX replace w/ memcpy */
@@ -2009,10 +2012,13 @@ uint32_t HELPER(mvcp)(CPUS390XState *env, uint64_t l,
uint64_t a1, uint64_t a2)
s390_program_interrupt(env, PGM_SPECIAL_OP, ILEN_AUTO, ra);
}
+ l = wrap_length32(env, l);
if (l > 256) {
/* max 256 */
l = 256;
cc = 3;
+ } else if (!l) {
+ return cc;
}
/* XXX replace w/ memcpy */
--
2.21.0
- [qemu-s390x] [PULL SUBSYSTEM s390x 02/29] s390x/tcg: MVCL: Zero out unused bits of address, (continued)
- [qemu-s390x] [PULL SUBSYSTEM s390x 02/29] s390x/tcg: MVCL: Zero out unused bits of address, David Hildenbrand, 2019/09/18
- [qemu-s390x] [PULL SUBSYSTEM s390x 03/29] s390x/tcg: MVCL: Detect destructive overlaps, David Hildenbrand, 2019/09/18
- [qemu-s390x] [PULL SUBSYSTEM s390x 04/29] s390x/tcg: MVCL: Process max 4k bytes at a time, David Hildenbrand, 2019/09/18
- [qemu-s390x] [PULL SUBSYSTEM s390x 05/29] s390x/tcg: MVC: Increment the length once, David Hildenbrand, 2019/09/18
- [qemu-s390x] [PULL SUBSYSTEM s390x 06/29] s390x/tcg: MVC: Use is_destructive_overlap(), David Hildenbrand, 2019/09/18
- [qemu-s390x] [PULL SUBSYSTEM s390x 08/29] s390x/tcg: MVPG: Properly wrap the addresses, David Hildenbrand, 2019/09/18
- [qemu-s390x] [PULL SUBSYSTEM s390x 07/29] s390x/tcg: MVPG: Check for specification exceptions, David Hildenbrand, 2019/09/18
- [qemu-s390x] [PULL SUBSYSTEM s390x 09/29] s390x/tcg: MVCLU/MVCLE: Process max 4k bytes at a time, David Hildenbrand, 2019/09/18
- [qemu-s390x] [PULL SUBSYSTEM s390x 10/29] s390x/tcg: MVCS/MVCP: Check for special operation exceptions, David Hildenbrand, 2019/09/18
- [qemu-s390x] [PULL SUBSYSTEM s390x 11/29] s390x/tcg: MVCOS: Lengths are 32 bit in 24/31-bit mode, David Hildenbrand, 2019/09/18
- [qemu-s390x] [PULL SUBSYSTEM s390x 12/29] s390x/tcg: MVCS/MVCP: Properly wrap the length,
David Hildenbrand <=
- [qemu-s390x] [PULL SUBSYSTEM s390x 13/29] s390x/tcg: MVST: Check for specification exceptions, David Hildenbrand, 2019/09/18
- [qemu-s390x] [PULL SUBSYSTEM s390x 14/29] s390x/tcg: MVST: Fix storing back the addresses to registers, David Hildenbrand, 2019/09/18
- [qemu-s390x] [PULL SUBSYSTEM s390x 15/29] s390x/tcg: Always use MMU_USER_IDX for CONFIG_USER_ONLY, David Hildenbrand, 2019/09/18
- [qemu-s390x] [PULL SUBSYSTEM s390x 16/29] s390x/tcg: Fault-safe memset, David Hildenbrand, 2019/09/18
- [qemu-s390x] [PULL SUBSYSTEM s390x 17/29] s390x/tcg: Fault-safe memmove, David Hildenbrand, 2019/09/18
- [qemu-s390x] [PULL SUBSYSTEM s390x 19/29] s390x/tcg: MVC: Fault-safe handling on destructive overlaps, David Hildenbrand, 2019/09/18
- [qemu-s390x] [PULL SUBSYSTEM s390x 18/29] s390x/tcg: MVCS/MVCP: Use access_memmove(), David Hildenbrand, 2019/09/18
- [qemu-s390x] [PULL SUBSYSTEM s390x 22/29] s390x/tcg: XC: Fault-safe handling, David Hildenbrand, 2019/09/18
- [qemu-s390x] [PULL SUBSYSTEM s390x 20/29] s390x/tcg: MVCLU: Fault-safe handling, David Hildenbrand, 2019/09/18
- [qemu-s390x] [PULL SUBSYSTEM s390x 21/29] s390x/tcg: OC: Fault-safe handling, David Hildenbrand, 2019/09/18