Re: [qemu-s390x] [Qemu-devel] [PATCH v3 16/29] s390x/tcg: Fault-safe memset

[Richard Henderson]

On 9/16/19 9:57 AM, David Hildenbrand wrote:
> Replace fast_memset() by access_memset(), that first tries to probe
> access to all affected pages (maximum is two). We'll use the same
> mechanism for other types of accesses soon.
> 
> Only in very rare cases (especially TLB_NOTDIRTY), we'll have to
> fallback to ld/st helpers. Try to speed up that case as suggested by
> Richard.
> 
> We'll rework most involved handlers soon to do all accesses via new
> fault-safe helpers, especially MVC.
> 
> Signed-off-by: David Hildenbrand <address@hidden>
> ---
>  target/s390x/mem_helper.c | 123 +++++++++++++++++++++++++++++++-------
>  1 file changed, 103 insertions(+), 20 deletions(-)

Reviewed-by: Richard Henderson <address@hidden>


r~