[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[qemu-s390x] [PATCH v3 07/29] s390x/tcg: MVPG: Check for specification e
From: |
David Hildenbrand |
Subject: |
[qemu-s390x] [PATCH v3 07/29] s390x/tcg: MVPG: Check for specification exceptions |
Date: |
Mon, 16 Sep 2019 15:57:44 +0200 |
Perform the checks documented in the PoP.
Reviewed-by: Richard Henderson <address@hidden>
Signed-off-by: David Hildenbrand <address@hidden>
---
target/s390x/mem_helper.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c
index c31cf49593..7dfa848744 100644
--- a/target/s390x/mem_helper.c
+++ b/target/s390x/mem_helper.c
@@ -672,6 +672,13 @@ uint64_t HELPER(clst)(CPUS390XState *env, uint64_t c,
uint64_t s1, uint64_t s2)
/* move page */
uint32_t HELPER(mvpg)(CPUS390XState *env, uint64_t r0, uint64_t r1, uint64_t
r2)
{
+ const bool f = extract64(r0, 11, 1);
+ const bool s = extract64(r0, 10, 1);
+
+ if ((f && s) || extract64(r0, 12, 4)) {
+ s390_program_interrupt(env, PGM_SPECIFICATION, ILEN_AUTO, GETPC());
+ }
+
/* ??? missing r0 handling, which includes access keys, but more
importantly optional suppression of the exception! */
fast_memmove(env, r1, r2, TARGET_PAGE_SIZE, GETPC());
--
2.21.0
- [qemu-s390x] [PATCH v3 00/29] s390x/tcg: mem_helper: Fault-safe handling, David Hildenbrand, 2019/09/16
- [qemu-s390x] [PATCH v3 01/29] s390x/tcg: Reset exception_index to -1 instead of 0, David Hildenbrand, 2019/09/16
- [qemu-s390x] [PATCH v3 02/29] s390x/tcg: MVCL: Zero out unused bits of address, David Hildenbrand, 2019/09/16
- [qemu-s390x] [PATCH v3 03/29] s390x/tcg: MVCL: Detect destructive overlaps, David Hildenbrand, 2019/09/16
- [qemu-s390x] [PATCH v3 04/29] s390x/tcg: MVCL: Process max 4k bytes at a time, David Hildenbrand, 2019/09/16
- [qemu-s390x] [PATCH v3 06/29] s390x/tcg: MVC: Use is_destructive_overlap(), David Hildenbrand, 2019/09/16
- [qemu-s390x] [PATCH v3 05/29] s390x/tcg: MVC: Increment the length once, David Hildenbrand, 2019/09/16
- [qemu-s390x] [PATCH v3 07/29] s390x/tcg: MVPG: Check for specification exceptions,
David Hildenbrand <=
- [qemu-s390x] [PATCH v3 09/29] s390x/tcg: MVCLU/MVCLE: Process max 4k bytes at a time, David Hildenbrand, 2019/09/16
- [qemu-s390x] [PATCH v3 08/29] s390x/tcg: MVPG: Properly wrap the addresses, David Hildenbrand, 2019/09/16
- [qemu-s390x] [PATCH v3 10/29] s390x/tcg: MVCS/MVCP: Check for special operation exceptions, David Hildenbrand, 2019/09/16
- [qemu-s390x] [PATCH v3 11/29] s390x/tcg: MVCOS: Lengths are 32 bit in 24/31-bit mode, David Hildenbrand, 2019/09/16
- [qemu-s390x] [PATCH v3 12/29] s390x/tcg: MVCS/MVCP: Properly wrap the length, David Hildenbrand, 2019/09/16
- [qemu-s390x] [PATCH v3 13/29] s390x/tcg: MVST: Check for specification exceptions, David Hildenbrand, 2019/09/16
- [qemu-s390x] [PATCH v3 14/29] s390x/tcg: MVST: Fix storing back the addresses to registers, David Hildenbrand, 2019/09/16