Re: [qemu-s390x] [PATCH v2] s390: cpumodel: fix description for the new vector facility

[Cornelia Huck]

On Mon,  8 Jul 2019 17:09:31 +0200
Christian Borntraeger <address@hidden> wrote:

> The new facility is called "Vector-Packed-Decimal-Enhancement Facility"
> and not "Vector BCD enhancements facility 1". As the shortname might
> have already found its way into some backports lets keep vxbeh.

s/lets/let's/

> 
> Fixes: 54d65de0b525 ("s390x/cpumodel: vector enhancements")
> Signed-off-by: Christian Borntraeger <address@hidden>
> ---
>  target/s390x/cpu_features_def.inc.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/target/s390x/cpu_features_def.inc.h 
> b/target/s390x/cpu_features_def.inc.h
> index ef190e2fc783..3118a9f89228 100644
> --- a/target/s390x/cpu_features_def.inc.h
> +++ b/target/s390x/cpu_features_def.inc.h
> @@ -104,7 +104,7 @@ DEF_FEAT(CMM_NT, "cmmnt", STFL, 147, "CMM: 
> ESSA-enhancement (no translate) facil
>  DEF_FEAT(VECTOR_ENH2, "vxeh2", STFL, 148, "Vector Enhancements facility 2")
>  DEF_FEAT(ESORT_BASE, "esort-base", STFL, 150, "Enhanced-sort facility 
> (excluding subfunctions)")
>  DEF_FEAT(DEFLATE_BASE, "deflate-base", STFL, 151, "Deflate-conversion 
> facility (excluding subfunctions)")
> -DEF_FEAT(VECTOR_BCD_ENH, "vxbeh", STFL, 152, "Vector BCD enhancements 
> facility 1")
> +DEF_FEAT(VECTOR_BCD_ENH, "vxbeh", STFL, 152, 
> "Vector-Packed-Decimal-Enhancement Facility")
>  DEF_FEAT(MSA_EXT_9, "msa9-base", STFL, 155, 
> "Message-security-assist-extension-9 facility (excluding subfunctions)")
>  DEF_FEAT(ETOKEN, "etoken", STFL, 156, "Etoken facility")
>  

I like this one better than v1, as it seems less risky (and I think we
can live with the odd shortname; it's not like all facilities are named
in an obvious way...)

I'll queue this first thing tomorrow, unless someone objects.