[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [qemu-s390x] [Qemu-trivial] [PATCH v2 02/10] hw/scsi: Use the QOM BU
From: |
Laurent Vivier |
Subject: |
Re: [qemu-s390x] [Qemu-trivial] [PATCH v2 02/10] hw/scsi: Use the QOM BUS() macro to access BusState.qbus |
Date: |
Thu, 6 Jun 2019 11:41:09 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 |
Le 28/05/2019 à 18:40, Philippe Mathieu-Daudé a écrit :
> Rather than looking inside the definition of a BusState with "s->bus.qbus",
> use the QOM prefered style: "BUS(&s->bus)".
>
> This patch was generated using the following Coccinelle script:
>
> // Use BUS() macros to access BusState.qbus
> @use_bus_macro_to_access_qbus@
> expression obj;
> identifier bus;
> @@
> -&obj->bus.qbus
> +BUS(&obj->bus)
>
> Suggested-by: Peter Maydell <address@hidden>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> hw/scsi/lsi53c895a.c | 2 +-
> hw/scsi/mptsas.c | 4 ++--
> hw/scsi/virtio-scsi.c | 2 +-
> 3 files changed, 4 insertions(+), 4 deletions(-)
>
Reviewed-by: Laurent Vivier <address@hidden>
- Re: [qemu-s390x] [Qemu-trivial] [PATCH v2 02/10] hw/scsi: Use the QOM BUS() macro to access BusState.qbus,
Laurent Vivier <=