Re: [qemu-s390x] [Qemu-trivial] [PATCH v2 04/10] hw/s390x/event-facility: Use the QOM BUS() macro to access BusState.qbus

[Laurent Vivier]

Le 28/05/2019 à 18:40, Philippe Mathieu-Daudé a écrit :
> Rather than looking inside the definition of a BusState with "s->bus.qbus",
> use the QOM prefered style: "BUS(&s->bus)".
> 
> This patch was generated using the following Coccinelle script:
> 
>     // Use BUS() macros to access BusState.qbus
>     @use_bus_macro_to_access_qbus@
>     expression obj;
>     identifier bus;
>     @@
>     -&obj->bus.qbus
>     +BUS(&obj->bus)
> 
> Suggested-by: Peter Maydell <address@hidden>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
>  hw/s390x/event-facility.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/s390x/event-facility.c b/hw/s390x/event-facility.c
> index ee5b83448b..e574223a22 100644
> --- a/hw/s390x/event-facility.c
> +++ b/hw/s390x/event-facility.c
> @@ -466,12 +466,12 @@ static void init_event_facility(Object *obj)
>      new = object_new(TYPE_SCLP_QUIESCE);
>      object_property_add_child(obj, TYPE_SCLP_QUIESCE, new, NULL);
>      object_unref(new);
> -    qdev_set_parent_bus(DEVICE(new), &event_facility->sbus.qbus);
> +    qdev_set_parent_bus(DEVICE(new), BUS(&event_facility->sbus));
>  
>      new = object_new(TYPE_SCLP_CPU_HOTPLUG);
>      object_property_add_child(obj, TYPE_SCLP_CPU_HOTPLUG, new, NULL);
>      object_unref(new);
> -    qdev_set_parent_bus(DEVICE(new), &event_facility->sbus.qbus);
> +    qdev_set_parent_bus(DEVICE(new), BUS(&event_facility->sbus));
>      /* the facility will automatically realize the devices via the bus */
>  }
>  
> 

Applied to my trivial-patches branch.

Thanks,
Laurent