[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [qemu-s390x] [Qemu-devel] [PATCH v3 06/10] hw/s390x: Replace global
From: |
Cornelia Huck |
Subject: |
Re: [qemu-s390x] [Qemu-devel] [PATCH v3 06/10] hw/s390x: Replace global smp variables with machine smp properties |
Date: |
Thu, 6 Jun 2019 09:56:21 +0200 |
On Wed, 5 Jun 2019 23:56:35 -0300
Eduardo Habkost <address@hidden> wrote:
> On Sun, May 19, 2019 at 04:54:24AM +0800, Like Xu wrote:
> > The global smp variables in s390x are replaced with smp machine properties.
> >
> > A local variable of the same name would be introduced in the declaration
> > phase if it's used widely in the context OR replace it on the spot if it's
> > only used once. No semantic changes.
> >
> > Signed-off-by: Like Xu <address@hidden>
>
> CCing s390 maintainers.
>
> Any objections to merging this through the Machine Core tree?
None at all.
>
> > ---
> > hw/s390x/s390-virtio-ccw.c | 3 ++-
> > hw/s390x/sclp.c | 2 +-
> > target/s390x/cpu.c | 3 +++
> > target/s390x/excp_helper.c | 5 +++++
> > 4 files changed, 11 insertions(+), 2 deletions(-)
Reviewed-by: Cornelia Huck <address@hidden>