[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[qemu-s390x] [PATCH v2 08/10] hw/usb-storage: Use the QOM DEVICE() macro
From: |
Philippe Mathieu-Daudé |
Subject: |
[qemu-s390x] [PATCH v2 08/10] hw/usb-storage: Use the QOM DEVICE() macro to access DeviceState.qdev |
Date: |
Tue, 28 May 2019 18:40:18 +0200 |
Rather than looking inside the definition of a DeviceState with
"s->qdev", use the QOM prefered style: "DEVICE(s)".
This patch was generated using the following Coccinelle script:
// Use DEVICE() macros to access DeviceState.qdev
@use_device_macro_to_access_qdev@
expression obj;
identifier dev;
@@
-&obj->dev.qdev
+DEVICE(obj)
Suggested-by: Peter Maydell <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
---
hw/usb/dev-storage.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/usb/dev-storage.c b/hw/usb/dev-storage.c
index cd5551d94f..0e4e93ef16 100644
--- a/hw/usb/dev-storage.c
+++ b/hw/usb/dev-storage.c
@@ -616,7 +616,7 @@ static void usb_msd_storage_realize(USBDevice *dev, Error
**errp)
* The hack is probably a bad idea.
*/
blk_ref(blk);
- blk_detach_dev(blk, &s->dev.qdev);
+ blk_detach_dev(blk, DEVICE(s));
s->conf.blk = NULL;
usb_desc_create_serial(dev);
--
2.20.1
- [qemu-s390x] [PATCH v2 00/10] qom: Use BUS()/DEVICE() macros instead of looking inside definitions, Philippe Mathieu-Daudé, 2019/05/28
- [qemu-s390x] [PATCH v2 04/10] hw/s390x/event-facility: Use the QOM BUS() macro to access BusState.qbus, Philippe Mathieu-Daudé, 2019/05/28
- [qemu-s390x] [PATCH v2 06/10] hw/audio/ac97: Use the QOM DEVICE() macro to access DeviceState.qdev, Philippe Mathieu-Daudé, 2019/05/28
- [qemu-s390x] [PATCH v2 02/10] hw/scsi: Use the QOM BUS() macro to access BusState.qbus, Philippe Mathieu-Daudé, 2019/05/28
- [qemu-s390x] [PATCH v2 08/10] hw/usb-storage: Use the QOM DEVICE() macro to access DeviceState.qdev,
Philippe Mathieu-Daudé <=
- [qemu-s390x] [PATCH v2 10/10] hw/watchdog/wdt_i6300esb: Use DEVICE() macro to access DeviceState.qdev, Philippe Mathieu-Daudé, 2019/05/28
- [qemu-s390x] [PATCH v2 05/10] hw/sd: Use the QOM BUS() macro to access BusState.qbus, Philippe Mathieu-Daudé, 2019/05/28
- [qemu-s390x] [PATCH v2 07/10] hw/isa: Use the QOM DEVICE() macro to access DeviceState.qdev, Philippe Mathieu-Daudé, 2019/05/28
- [qemu-s390x] [PATCH v2 03/10] hw/pci-bridge: Use the QOM BUS() macro to access BusState.qbus, Philippe Mathieu-Daudé, 2019/05/28
- [qemu-s390x] [PATCH v2 01/10] hw/scsi/vmw_pvscsi: Use qbus_reset_all() directly, Philippe Mathieu-Daudé, 2019/05/28
- [qemu-s390x] [PATCH v2 09/10] hw/vfio/pci: Use the QOM DEVICE() macro to access DeviceState.qdev, Philippe Mathieu-Daudé, 2019/05/28