Re: [qemu-s390x] [Qemu-devel] [PATCH v1 29/41] s390x/tcg: Implement VECTOR ELEMENT SHIFT

[Richard Henderson]

On 4/11/19 12:08 AM, David Hildenbrand wrote:
> Only for one special case we can reuse real gvec helpers. Mostly
> rely on oom helpers.
> 
> One important thing to take care of is always to properly mask of
> unused bits from the shift count.
> 
> Signed-off-by: David Hildenbrand <address@hidden>
> ---
>  target/s390x/helper.h           |  18 +++++
>  target/s390x/insn-data.def      |   9 +++
>  target/s390x/translate_vx.inc.c | 113 ++++++++++++++++++++++++++++++++
>  target/s390x/vec_int_helper.c   |  99 ++++++++++++++++++++++++++++
>  4 files changed, 239 insertions(+)

Again, I should fill out these in gvec...

Reviewed-by: Richard Henderson <address@hidden>


r~