[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [qemu-s390x] [Qemu-devel] [PATCH v1 29/33] s390x/tcg: Implement VECT
From: |
David Hildenbrand |
Subject: |
Re: [qemu-s390x] [Qemu-devel] [PATCH v1 29/33] s390x/tcg: Implement VECTOR STORE |
Date: |
Thu, 28 Feb 2019 10:11:57 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 |
On 28.02.19 00:46, Richard Henderson wrote:
> On 2/26/19 3:39 AM, David Hildenbrand wrote:
>> +static DisasJumpType op_vst(DisasContext *s, DisasOps *o)
>> +{
>> + /*
>> + * FIXME: On exceptions we must not modify any memory.
>> + */
>> + store_vec_element(s, get_field(s->fields, v1), 0, o->addr1, MO_64);
>> + gen_addi_and_wrap_i64(s, o->addr1, o->addr1, 8);
>> + store_vec_element(s, get_field(s->fields, v1), 1, o->addr1, MO_64);
>> + return DISAS_NEXT;
>
> Should handle alignment though.
Again, as unaligned access must not trigger an exception, I don't think
we can use MO_ALIGN.
>
> FWIW, there is a probe_write function that can be called to make sure a region
> is writable before actually accessing it. But this is common enough that we
> should probably just handle 16-byte quantities as a native tcg type.
That would make most sense. It won't help for the VECTOR_STORE_MULTIPLE
part, though.
I'll keep it as is for now.
Thanks!
>
> Reviewed-by: Richard Henderson <address@hidden>
>
>
> r~
>
--
Thanks,
David / dhildenb
- Re: [qemu-s390x] [Qemu-devel] [PATCH v1 26/33] s390x/tcg: Implement VECTOR SCATTER ELEMENT, (continued)
- [qemu-s390x] [PATCH v1 28/33] s390x/tcg: Implement VECTOR SIGN EXTEND TO DOUBLEWORD, David Hildenbrand, 2019/02/26
- [qemu-s390x] [PATCH v1 31/33] s390x/tcg: Implement VECTOR STORE MULTIPLE, David Hildenbrand, 2019/02/26
- [qemu-s390x] [PATCH v1 27/33] s390x/tcg: Implement VECTOR SELECT, David Hildenbrand, 2019/02/26
- [qemu-s390x] [PATCH v1 29/33] s390x/tcg: Implement VECTOR STORE, David Hildenbrand, 2019/02/26
- [qemu-s390x] [PATCH v1 30/33] s390x/tcg: Implement VECTOR STORE ELEMENT, David Hildenbrand, 2019/02/26
- [qemu-s390x] [PATCH v1 32/33] s390x/tcg: Implement VECTOR STORE WITH LENGTH, David Hildenbrand, 2019/02/26
- [qemu-s390x] [PATCH v1 33/33] s390x/tcg: Implement VECTOR UNPACK *, David Hildenbrand, 2019/02/26