Re: [qemu-s390x] [PATCH v1 1/7] s390x/tcg: RXE has an optional M3 field

[Thomas Huth]

On 25/02/2019 12.55, David Hildenbrand wrote:
> Will be needed, so add it to the format description.
> 
> Signed-off-by: David Hildenbrand <address@hidden>
> ---
>  target/s390x/insn-format.def | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/target/s390x/insn-format.def b/target/s390x/insn-format.def
> index a412d90fb7..4297ff4165 100644
> --- a/target/s390x/insn-format.def
> +++ b/target/s390x/insn-format.def
> @@ -36,7 +36,7 @@ F3(RSY_a, R(1, 8),     BDL(2),      R(3,12))
>  F3(RSY_b, R(1, 8),     BDL(2),      M(3,12))
>  F2(RX_a,  R(1, 8),     BXD(2))
>  F2(RX_b,  M(1, 8),     BXD(2))
> -F2(RXE,   R(1, 8),     BXD(2))
> +F3(RXE,   R(1, 8),     BXD(2),      M(3,32))

Yes, according to the Principles of Operations, RXE has a M3 field.

Reviewed-by: Thomas Huth <address@hidden>