[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [qemu-s390x] [PATCH v2 1/3] s390x/cpumodel: mepochptff: warn when no
From: |
Cornelia Huck |
Subject: |
Re: [qemu-s390x] [PATCH v2 1/3] s390x/cpumodel: mepochptff: warn when no mepoch and re-align group init |
Date: |
Tue, 12 Feb 2019 11:04:39 +0100 |
On Mon, 11 Feb 2019 20:16:55 -0500
Collin Walling <address@hidden> wrote:
> The extended PTFF features (qsie, qtoue, stoe, stoue) are dependent
> on the multiple-epoch facility (mepoch). Let's print a warning if these
> features are enabled without mepoch.
>
> While we're at it, let's move the FEAT_GROUP_INIT for mepochptff down
> the s390_feature_groups list so it can be properly indexed with its
> generated S390FeatGroup enum.
>
> Signed-off-by: Collin Walling <address@hidden>
> ---
> target/s390x/cpu_features.c | 2 +-
> target/s390x/cpu_models.c | 4 ++++
> 2 files changed, 5 insertions(+), 1 deletion(-)
Not a comment for this patch (looks fine to me), but more general:
Could you please add a cover letter if you send more than one patch?
It's easy to miss that there are three patches and not two :)
- [qemu-s390x] [PATCH v2 1/3] s390x/cpumodel: mepochptff: warn when no mepoch and re-align group init, Collin Walling, 2019/02/11
- [qemu-s390x] [PATCH v2 2/3] s390x/cpumodel: default enable mepoch for z14 and later, Collin Walling, 2019/02/11
- [qemu-s390x] [PATCH v2 3/3] s390x/cpumodel: add z14 GA2 model, Collin Walling, 2019/02/11
- Re: [qemu-s390x] [PATCH v2 1/3] s390x/cpumodel: mepochptff: warn when no mepoch and re-align group init,
Cornelia Huck <=
- Re: [qemu-s390x] [PATCH v2 1/3] s390x/cpumodel: mepochptff: warn when no mepoch and re-align group init, Christian Borntraeger, 2019/02/12
- Re: [qemu-s390x] [PATCH v2 1/3] s390x/cpumodel: mepochptff: warn when no mepoch and re-align group init, David Hildenbrand, 2019/02/12
- Re: [qemu-s390x] [PATCH v2 1/3] s390x/cpumodel: mepochptff: warn when no mepoch and re-align group init, Cornelia Huck, 2019/02/13