[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [qemu-s390x] [PATCH v2 3/6] terminal3270: do not use backend timer s
|
From: |
Cornelia Huck |
|
Subject: |
Re: [qemu-s390x] [PATCH v2 3/6] terminal3270: do not use backend timer sources |
|
Date: |
Thu, 7 Feb 2019 18:14:15 +0100 |
On Wed, 6 Feb 2019 18:43:25 +0100
Marc-André Lureau <address@hidden> wrote:
> terminal3270 uses the front-end side of the chardev. It shouldn't
> create sources from backend side context (with backend
> functions).
>
> send_timing_mark_cb calls qemu_chr_fe_write_all() which should be
> thread safe.
>
> This partially reverts changes from commit
> 2c716ba1506769c9be2caa02f0f6d6e7c00f4304.
>
> CC: Peter Xu <address@hidden>
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
> hw/char/terminal3270.c | 15 ++++++---------
> 1 file changed, 6 insertions(+), 9 deletions(-)
I've verified that 3270 continues to work as before.
Acked-by: Cornelia Huck <address@hidden>