Re: [qemu-s390x] [PATCH v10 4/6] s390x/ap: base Adjunct Processor (AP) object model

[Cornelia Huck]

On Wed, 10 Oct 2018 09:59:55 -0400
Tony Krowiak <address@hidden> wrote:

> On 10/10/2018 04:14 AM, Cornelia Huck wrote:
> > On Tue,  9 Oct 2018 13:52:24 -0400
> > Tony Krowiak <address@hidden> wrote:
> >   
> >> diff --git a/hw/s390x/ap-device.c b/hw/s390x/ap-device.c
> >> new file mode 100644
> >> index 000000000000..fb6e35024c82
> >> --- /dev/null
> >> +++ b/hw/s390x/ap-device.c
> >> @@ -0,0 +1,39 @@
> >> +/*
> >> + * Adjunct Processor (AP) matrix device
> >> + *
> >> + * Copyright 2018 IBM Corp.
> >> + * Author(s): Tony Krowiak <address@hidden>  
> > 
> > Do you also want this to use the vnet-less form instead?
> >   
> >> + *
> >> + * This work is licensed under the terms of the GNU GPL, version 2 or (at
> >> + * your option) any later version. See the COPYING file in the top-level
> >> + * directory.
> >> + */  
> >   
> >> diff --git a/include/hw/s390x/ap-device.h b/include/hw/s390x/ap-device.h
> >> new file mode 100644
> >> index 000000000000..4fb3c9ab82f2
> >> --- /dev/null
> >> +++ b/include/hw/s390x/ap-device.h
> >> @@ -0,0 +1,23 @@
> >> +/*
> >> + * Adjunct Processor (AP) matrix device interfaces
> >> + *
> >> + * Copyright 2018 IBM Corp.
> >> + * Author(s): Tony Krowiak <address@hidden>  
> > 
> > Same here.  
> 
> Yes. Shall I just submit a v11?

Please submit a v11 with the various things mentioned during review
(and the r-bs etc. collected).