Re: [qemu-s390x] [PATCH v3 8/9] s390x/tcg: fix FP register pair checks

[David Hildenbrand]

On 27/09/2018 13:29, Thomas Huth wrote:
> On 2018-09-17 11:34, David Hildenbrand wrote:
>> Valid register pairs are 0/2, 1/3, 4/6, 5/7, 8/10, 9/11, 12/14, 13/15.
>>
>> R1/R2 always selects the lower number, so the current checks are not
>> correct as e.g. 2/4 could be selected as a pair.
>>
>> Reviewed-by: Richard Henderson <address@hidden>
>> Signed-off-by: David Hildenbrand <address@hidden>
>> ---
>>  target/s390x/translate.c | 22 +++++++++++-----------
>>  1 file changed, 11 insertions(+), 11 deletions(-)
>>
>> diff --git a/target/s390x/translate.c b/target/s390x/translate.c
>> index f9a78c4304..5cc65b0840 100644
>> --- a/target/s390x/translate.c
>> +++ b/target/s390x/translate.c
>> @@ -1110,7 +1110,7 @@ typedef struct {
>>  #define IF_HFP3     0x0004      /* r3 points at fp reg for HFP instructions 
>> */
>>  #define IF_BFP      0x0008      /* binary floating point instruction */
>>  #define IF_DFP      0x0010      /* decimal floating point instruction */
>> -#define IF_PRIV     0x0020      /* priviledged instruction */
>> +#define IF_PRIV     0x0020      /* privileged instruction */
> 
> Ah, well, merge this with the previous patch, please.
> 

I thought I already did that *scratches head*. Thanks


-- 

Thanks,

David / dhildenb