Re: [qemu-s390x] [RFC PATCH 2/2] s390: add cpu feat and migration support for diagnose 318

[Thomas Huth]

On 2018-08-31 19:28, Collin Walling wrote:
> Add a new CPU model feature, diag318, that allows for configuration of a
> VM to use the diagnose 318 instruction call. This feature is made available
> starting with the zEC12-full CPU model.
> 
> Migration is supported for the diag318 related data (the "CPC").
> 
> This new feature relies on KVM support.
> 
> Signed-off-by: Collin Walling <address@hidden>
> ---
>  hw/s390x/s390-virtio-ccw.c      |  2 ++
>  hw/s390x/sclp.c                 |  2 ++
>  include/hw/s390x/sclp.h         |  2 ++
>  target/s390x/cpu.c              |  7 +++++++
>  target/s390x/cpu.h              |  3 +++
>  target/s390x/cpu_features.c     |  3 +++
>  target/s390x/cpu_features.h     |  1 +
>  target/s390x/cpu_features_def.h |  3 +++
>  target/s390x/gen-features.c     |  1 +
>  target/s390x/kvm.c              | 12 +++++++++++
>  target/s390x/kvm_s390x.h        |  1 +
>  target/s390x/machine.c          | 46 
> +++++++++++++++++++++++++++++++++++++++++
[...]
> diff --git a/hw/s390x/sclp.c b/hw/s390x/sclp.c
> index 4510a80..aaaec86 100644
> --- a/hw/s390x/sclp.c
> +++ b/hw/s390x/sclp.c
> @@ -73,6 +73,8 @@ static void read_SCP_info(SCLPDevice *sclp, SCCB *sccb)
>                           read_info->conf_char);
>      s390_get_feat_block(S390_FEAT_TYPE_SCLP_CONF_CHAR_EXT,
>                           read_info->conf_char_ext);
> +    s390_get_feat_block(S390_FEAT_TYPE_SCLP_CONF_FAC134,
> +                         read_info->fac134);

Cosmetic nit: This still fits into one line only, no need to break it up.

 Thomas