Re: [qemu-s390x] [PATCH 2/2] s390x/kvm: add etoken facility

[Cornelia Huck]

On Tue, 31 Jul 2018 12:14:28 +0200
Christian Borntraeger <address@hidden> wrote:

> On 07/31/2018 11:44 AM, Cornelia Huck wrote:
> > On Tue, 31 Jul 2018 11:04:48 +0200
> > Christian Borntraeger <address@hidden> wrote:
> >   
> >> Provide the etoken facility. We need to handle cpu model, migration and
> >> clear reset.  
> >   ^^^^^^^^^^^  
> 
> Clear reset is the "strong one". Here we do a memset of the env structure.
> So this should be cleared along with the other registers.

I was confused why it was singled out...

> > 
> > Hm, anything special for that? I don't see it in the patch.
> >   
> >>
> >> Signed-off-by: Christian Borntraeger <address@hidden>
> >> Acked-by: Janosch Frank <address@hidden>
> >> ---
> >>  target/s390x/cpu.h              |  3 +++
> >>  target/s390x/cpu_features.c     |  3 ++-
> >>  target/s390x/cpu_features_def.h |  3 ++-
> >>  target/s390x/gen-features.c     |  3 ++-
> >>  target/s390x/kvm.c              | 11 +++++++++++
> >>  target/s390x/machine.c          | 20 +++++++++++++++++++-
> >>  6 files changed, 39 insertions(+), 4 deletions(-)  
> >   
>