|
| From: | Christian Borntraeger |
| Subject: | Re: [qemu-s390x] [RFC 10/15] s390-bios: Support for running format-0/1 channel programs |
| Date: | Mon, 9 Jul 2018 09:18:41 +0200 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 07/05/2018 07:25 PM, Jason J. Herne wrote:
> From: "Jason J. Herne" <address@hidden>
> +void await_io_int(uint16_t sch_no)
> +{
> + /*
> + * wait_psw and ctl6 must be static to avoid stack allocation as gcc
> cannot
> + * align stack variables. The stctg, lctlg and lpswe instructions require
> + * that their operands be aligned on an 8-byte boundary.
> + */
In fact, the ABI guarantees that the stack is always 8 byte aligned and gcc
should
align any uint64_t to 8 byte as well on the stack.
> + static uint64_t ctl6 __attribute__((__aligned__(8)));
> + static PSW wait_psw;
> +
| [Prev in Thread] | Current Thread | [Next in Thread] |