[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[qemu-s390x] [PULL 09/15] s390x/tcg: SET CLOCK COMPARATOR can clear CKC
From: |
Cornelia Huck |
Subject: |
[qemu-s390x] [PULL 09/15] s390x/tcg: SET CLOCK COMPARATOR can clear CKC interrupts |
Date: |
Mon, 2 Jul 2018 13:17:31 +0200 |
From: David Hildenbrand <address@hidden>
Let's stop the timer and delete any pending CKC IRQ before doing
anything else.
While at it, add a comment why the check for ckc == -1ULL is needed.
Reviewed-by: Thomas Huth <address@hidden>
Signed-off-by: David Hildenbrand <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Cornelia Huck <address@hidden>
---
target/s390x/misc_helper.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/target/s390x/misc_helper.c b/target/s390x/misc_helper.c
index 229f14d3da..e4c1522140 100644
--- a/target/s390x/misc_helper.c
+++ b/target/s390x/misc_helper.c
@@ -154,6 +154,13 @@ void HELPER(sckc)(CPUS390XState *env, uint64_t time)
{
S390TODState *td = s390_get_todstate();
+ /* stop the timer and remove pending CKC IRQs */
+ timer_del(env->tod_timer);
+ qemu_mutex_lock_iothread();
+ env->pending_int &= ~INTERRUPT_EXT_CLOCK_COMPARATOR;
+ qemu_mutex_unlock_iothread();
+
+ /* the tod has to exceed the ckc, this can never happen if ckc is all 1's
*/
if (time == -1ULL) {
return;
}
--
2.14.4
- [qemu-s390x] [PULL 00/15] s390x patches for 3.0, Cornelia Huck, 2018/07/02
- [qemu-s390x] [PULL 01/15] s390/ipl: fix ipl with -no-reboot, Cornelia Huck, 2018/07/02
- [qemu-s390x] [PULL 02/15] loader: Check access size when calling rom_ptr() to avoid crashes, Cornelia Huck, 2018/07/02
- [qemu-s390x] [PULL 03/15] s390x/cpumodel: default enable bpb and ppa15 for z196 and later, Cornelia Huck, 2018/07/02
- [qemu-s390x] [PULL 04/15] s390x/tcg: avoid overflows in time2tod/tod2time, Cornelia Huck, 2018/07/02
- [qemu-s390x] [PULL 05/15] s390x/kvm: pass values instead of pointers to kvm_s390_set_clock_*(), Cornelia Huck, 2018/07/02
- [qemu-s390x] [PULL 07/15] s390x/tcg: drop tod_basetime, Cornelia Huck, 2018/07/02
- [qemu-s390x] [PULL 09/15] s390x/tcg: SET CLOCK COMPARATOR can clear CKC interrupts,
Cornelia Huck <=
- [qemu-s390x] [PULL 08/15] s390x/tcg: properly implement the TOD, Cornelia Huck, 2018/07/02
- [qemu-s390x] [PULL 06/15] s390x/tod: factor out TOD into separate device, Cornelia Huck, 2018/07/02
- [qemu-s390x] [PULL 11/15] s390x/tcg: rearm the CKC timer during migration, Cornelia Huck, 2018/07/02
- [qemu-s390x] [PULL 13/15] s390x/kvm: legacy_s390_alloc() only supports one allocation, Cornelia Huck, 2018/07/02
- [qemu-s390x] [PULL 10/15] s390x/tcg: implement SET CLOCK, Cornelia Huck, 2018/07/02
- [qemu-s390x] [PULL 12/15] s390x/tcg: fix CPU hotplug with single-threaded TCG, Cornelia Huck, 2018/07/02
- [qemu-s390x] [PULL 14/15] s390x/kvm: indicate alignment in legacy_s390_alloc(), Cornelia Huck, 2018/07/02
- [qemu-s390x] [PULL 15/15] s390x/tcg: fix locking problem with tcg_s390_tod_updated, Cornelia Huck, 2018/07/02
- Re: [qemu-s390x] [PULL 00/15] s390x patches for 3.0, Peter Maydell, 2018/07/02