[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[qemu-s390x] [PATCH v4 6/9] s390x/tcg: SET CLOCK COMPARATOR can clear CK
From: |
David Hildenbrand |
Subject: |
[qemu-s390x] [PATCH v4 6/9] s390x/tcg: SET CLOCK COMPARATOR can clear CKC interrupts |
Date: |
Wed, 27 Jun 2018 15:44:07 +0200 |
Let's stop the timer and delete any pending CKC IRQ before doing
anything else.
While at it, add a comment why the check for ckc == -1ULL is needed.
Reviewed-by: Thomas Huth <address@hidden>
Signed-off-by: David Hildenbrand <address@hidden>
---
target/s390x/misc_helper.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/target/s390x/misc_helper.c b/target/s390x/misc_helper.c
index 229f14d3da..e4c1522140 100644
--- a/target/s390x/misc_helper.c
+++ b/target/s390x/misc_helper.c
@@ -154,6 +154,13 @@ void HELPER(sckc)(CPUS390XState *env, uint64_t time)
{
S390TODState *td = s390_get_todstate();
+ /* stop the timer and remove pending CKC IRQs */
+ timer_del(env->tod_timer);
+ qemu_mutex_lock_iothread();
+ env->pending_int &= ~INTERRUPT_EXT_CLOCK_COMPARATOR;
+ qemu_mutex_unlock_iothread();
+
+ /* the tod has to exceed the ckc, this can never happen if ckc is all 1's
*/
if (time == -1ULL) {
return;
}
--
2.17.1
- [qemu-s390x] [PATCH v4 0/9] s390x: TOD refactoring + TCG CPU hotplug support, David Hildenbrand, 2018/06/27
- [qemu-s390x] [PATCH v4 2/9] s390x/kvm: pass values instead of pointers to kvm_s390_set_clock_*(), David Hildenbrand, 2018/06/27
- [qemu-s390x] [PATCH v4 1/9] s390x/tcg: avoid overflows in time2tod/tod2time, David Hildenbrand, 2018/06/27
- [qemu-s390x] [PATCH v4 4/9] s390x/tcg: drop tod_basetime, David Hildenbrand, 2018/06/27
- [qemu-s390x] [PATCH v4 6/9] s390x/tcg: SET CLOCK COMPARATOR can clear CKC interrupts,
David Hildenbrand <=
- [qemu-s390x] [PATCH v4 9/9] s390x/tcg: fix CPU hotplug with single-threaded TCG, David Hildenbrand, 2018/06/27
- [qemu-s390x] [PATCH v4 7/9] s390x/tcg: implement SET CLOCK, David Hildenbrand, 2018/06/27
- [qemu-s390x] [PATCH v4 8/9] s390x/tcg: rearm the CKC timer during migration, David Hildenbrand, 2018/06/27
- [qemu-s390x] [PATCH v4 5/9] s390x/tcg: properly implement the TOD, David Hildenbrand, 2018/06/27
- [qemu-s390x] [PATCH v4 3/9] s390x/tod: factor out TOD into separate device, David Hildenbrand, 2018/06/27
- Re: [qemu-s390x] [PATCH v4 0/9] s390x: TOD refactoring + TCG CPU hotplug support, Cornelia Huck, 2018/06/27