[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [qemu-s390x] [PATCH v3 9/9] s390x/tcg: fix CPU hotplug with single-t
|
From: |
Thomas Huth |
|
Subject: |
Re: [qemu-s390x] [PATCH v3 9/9] s390x/tcg: fix CPU hotplug with single-threaded TCG |
|
Date: |
Wed, 27 Jun 2018 13:19:22 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 25.06.2018 13:53, David Hildenbrand wrote:
> run_on_cpu() doesn't seem to work reliably until the CPU has been fully
> created if the single-threaded TCG main loop is already running.
>
> Therefore, hotplugging a CPU under single-threaded TCG does currently
> not work. We should use the direct call instead of going via
> run_on_cpu().
>
> So let's use run_on_cpu() for KVM only - KVM requires it due to the initial
> CPU reset ioctl. As a nice side effect, we get rif of the ifdef.
With the typo fixed:
Reviewed-by: Thomas Huth <address@hidden>
- Re: [qemu-s390x] [PATCH v3 6/9] s390x/tcg: SET CLOCK COMPARATOR can clear CKC interrupts, (continued)
[qemu-s390x] [PATCH v3 9/9] s390x/tcg: fix CPU hotplug with single-threaded TCG, David Hildenbrand, 2018/06/25