[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [qemu-s390x] [PATCH v1] s390x: refactor reset/reipl handling
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [qemu-s390x] [PATCH v1] s390x: refactor reset/reipl handling |
|
Date: |
Thu, 21 Jun 2018 18:59:45 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 21/06/2018 18:08, David Hildenbrand wrote:
>> Without this we have no kdump/kexec/ipl
>> as soon as somebody uses -no-reboot.
>>
> Paolo even said that consistent -no-reboot handling would be one of the
> benefits :)
>
kdump/kexec (and of course "ipl") do not reboot on x86, so fixing the
bug does help in making things consistent. :)
Do we really want a reset event for ipl? Maybe for kexec/kdump, but
perhaps just using SHUTDOWN_CAUSE_NONE for MODIFIED_CLEAR and
LOAD_NORMAL (not sure about the difference) is the way to go.
For example, x86 suspend is a "reboot" but it is already special cased
to use SHUTDOWN_CAUSE_NONE.
Paolo