[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [qemu-s390x] [Qemu-devel] [PATCH v4 05/14] pc: route all memory devi
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [qemu-s390x] [Qemu-devel] [PATCH v4 05/14] pc: route all memory devices through the machine hotplug handler |
|
Date: |
Wed, 30 May 2018 16:27:40 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 30/05/2018 16:08, David Hildenbrand wrote:
>>> if (object_dynamic_cast(OBJECT(dev), TYPE_PC_DIMM) ||
>>> + object_dynamic_cast(OBJECT(dev), TYPE_MEMORY_DEVICE) ||
>> you probably could drop TYPE_PC_DIMM above, it's redundant since DIMM
>> can be cast to TYPE_MEMORY_DEVICE
>>
>> ditto for spapr
>>
> Yes, had the same in mind but left it for now this way (basically
> because we do special handling for PC_DIMM, so anybody reading this code
> is not directly confused)
>
Hmm, I think what Igor proposes is nicer. Can you send a v5 when he's
done with review?
Paolo
[qemu-s390x] [PATCH v4 02/14] memory-device: introduce separate config option, David Hildenbrand, 2018/05/17
[qemu-s390x] [PATCH v4 01/14] memory-device: drop assert related to align and start of address space, David Hildenbrand, 2018/05/17
[qemu-s390x] [PATCH v4 06/14] spapr: prepare for multi stage hotplug handlers, David Hildenbrand, 2018/05/17