[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[qemu-s390x] [PATCH v1 7/7] s390x/tcg: fix CPU hotplug with single-threa
From: |
David Hildenbrand |
Subject: |
[qemu-s390x] [PATCH v1 7/7] s390x/tcg: fix CPU hotplug with single-threaded TCG |
Date: |
Fri, 25 May 2018 13:37:08 +0200 |
run_on_cpu() doesn't seem to work reliably until the CPU has been fully
created if the single-threaded TCG main loop is already running.
Therefore, let's use run_on_cpu() for KVM only - KVM requires it due to
the initial CPU reset ioctl.
Signed-off-by: David Hildenbrand <address@hidden>
---
target/s390x/cpu.c | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/target/s390x/cpu.c b/target/s390x/cpu.c
index e4d7e82a23..5fceed7948 100644
--- a/target/s390x/cpu.c
+++ b/target/s390x/cpu.c
@@ -220,11 +220,12 @@ static void s390_cpu_realizefn(DeviceState *dev, Error
**errp)
#endif
s390_cpu_gdb_init(cs);
qemu_init_vcpu(cs);
-#if !defined(CONFIG_USER_ONLY)
- run_on_cpu(cs, s390_do_cpu_full_reset, RUN_ON_CPU_NULL);
-#else
- cpu_reset(cs);
-#endif
+
+ if (kvm_enabled()) {
+ run_on_cpu(cs, s390_do_cpu_full_reset, RUN_ON_CPU_NULL);
+ } else {
+ cpu_reset(cs);
+ }
scc->parent_realize(dev, &err);
out:
--
2.17.0
- [qemu-s390x] [PATCH v1 0/7] s390x: TOD refactoring + TCG CPU hotplug support, David Hildenbrand, 2018/05/25
- [qemu-s390x] [PATCH v1 2/7] s390x/tcg: drop tod_basetime, David Hildenbrand, 2018/05/25
- [qemu-s390x] [PATCH v1 1/7] s390x/tod: factor out TOD into separate device, David Hildenbrand, 2018/05/25
- [qemu-s390x] [PATCH v1 4/7] s390x/tcg: SET CLOCK COMPARATOR can clear CKC interrupts, David Hildenbrand, 2018/05/25
- [qemu-s390x] [PATCH v1 3/7] s390x/tcg: properly implement the TOD, David Hildenbrand, 2018/05/25
- [qemu-s390x] [PATCH v1 5/7] s390x/tcg: implement SET CLOCK, David Hildenbrand, 2018/05/25
- [qemu-s390x] [PATCH v1 6/7] s390x/tcg: rearm the CKC timer during migration, David Hildenbrand, 2018/05/25
- [qemu-s390x] [PATCH v1 7/7] s390x/tcg: fix CPU hotplug with single-threaded TCG,
David Hildenbrand <=