|
From: | Halil Pasic |
Subject: | Re: [qemu-s390x] [Qemu-devel] [PATCH 1/1] virtio-ccw: clean up notify |
Date: | Thu, 17 May 2018 20:27:03 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 05/17/2018 05:26 PM, Cornelia Huck wrote:
On Wed, 16 May 2018 15:27:57 +0200 Halil Pasic <address@hidden> wrote:Coverity recently started complaining about virtio_ccw_notify(). Turns out, there is a couple of things that can be cleaned up. Let's clean!Changes look good to me. I wanted to come up with a better patch description, but failed (well, I did not try much.) So I'm inclined to merge this as-is.
I also gave up on a good patch description real soon. The patch does not do a single thing, but I don't think splitting it up would make things better. So I was like: the changes are pretty straight-forward, and the commit message should just hint refactoring. Thanks! Halil
Reported-by: Peter Maydell <address@hidden> Fixes: CID 1390619 Signed-off-by: Halil Pasic <address@hidden> --- hw/s390x/virtio-ccw.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-)
[Prev in Thread] | Current Thread | [Next in Thread] |