[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[qemu-s390x] [PATCH v4 09/14] spapr: handle cpu core unplug via hotplug
From: |
David Hildenbrand |
Subject: |
[qemu-s390x] [PATCH v4 09/14] spapr: handle cpu core unplug via hotplug handler chain |
Date: |
Thu, 17 May 2018 10:15:22 +0200 |
Let's handle it via hotplug_handler_unplug().
Signed-off-by: David Hildenbrand <address@hidden>
---
hw/ppc/spapr.c | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
index 286c38c842..13d153b5a6 100644
--- a/hw/ppc/spapr.c
+++ b/hw/ppc/spapr.c
@@ -3412,7 +3412,16 @@ static void *spapr_populate_hotplug_cpu_dt(CPUState *cs,
int *fdt_offset,
/* Callback to be called during DRC release. */
void spapr_core_release(DeviceState *dev)
{
- MachineState *ms = MACHINE(qdev_get_hotplug_handler(dev));
+ HotplugHandler *hotplug_ctrl = qdev_get_hotplug_handler(dev);
+
+ /* Call the unplug handler chain. This can never fail. */
+ hotplug_handler_unplug(hotplug_ctrl, dev, &error_abort);
+}
+
+static void spapr_core_unplug(HotplugHandler *hotplug_dev, DeviceState *dev,
+ Error **errp)
+{
+ MachineState *ms = MACHINE(hotplug_dev);
sPAPRMachineClass *smc = SPAPR_MACHINE_GET_CLASS(ms);
CPUCore *cc = CPU_CORE(dev);
CPUArchId *core_slot = spapr_find_cpu_slot(ms, cc->core_id, NULL);
@@ -3623,6 +3632,8 @@ static void spapr_machine_device_unplug(HotplugHandler
*hotplug_dev,
/* final stage hotplug handler */
if (object_dynamic_cast(OBJECT(dev), TYPE_PC_DIMM)) {
spapr_memory_unplug(hotplug_dev, dev, &local_err);
+ } else if (object_dynamic_cast(OBJECT(dev), TYPE_SPAPR_CPU_CORE)) {
+ spapr_core_unplug(hotplug_dev, dev, &local_err);
} else if (dev->parent_bus && dev->parent_bus->hotplug_handler) {
hotplug_handler_unplug(dev->parent_bus->hotplug_handler, dev,
&local_err);
--
2.14.3
- Re: [qemu-s390x] [PATCH v4 01/14] memory-device: drop assert related to align and start of address space, (continued)
[qemu-s390x] [PATCH v4 06/14] spapr: prepare for multi stage hotplug handlers, David Hildenbrand, 2018/05/17
[qemu-s390x] [PATCH v4 04/14] pc: prepare for multi stage hotplug handlers, David Hildenbrand, 2018/05/17
[qemu-s390x] [PATCH v4 08/14] spapr: handle pc-dimm unplug via hotplug handler chain, David Hildenbrand, 2018/05/17
[qemu-s390x] [PATCH v4 07/14] spapr: route all memory devices through the machine hotplug handler, David Hildenbrand, 2018/05/17
[qemu-s390x] [PATCH v4 09/14] spapr: handle cpu core unplug via hotplug handler chain,
David Hildenbrand <=
[qemu-s390x] [PATCH v4 11/14] pc-dimm: implement new memory device functions, David Hildenbrand, 2018/05/17
[qemu-s390x] [PATCH v4 12/14] memory-device: factor out pre-plug into hotplug handler, David Hildenbrand, 2018/05/17
[qemu-s390x] [PATCH v4 10/14] memory-device: new functions to handle plug/unplug, David Hildenbrand, 2018/05/17
[qemu-s390x] [PATCH v4 13/14] memory-device: factor out unplug into hotplug handler, David Hildenbrand, 2018/05/17
[qemu-s390x] [PATCH v4 14/14] memory-device: factor out plug into hotplug handler, David Hildenbrand, 2018/05/17
Re: [qemu-s390x] [PATCH v4 00/14] MemoryDevice: use multi stage hotplug handlers, David Hildenbrand, 2018/05/25