Re: [qemu-s390x] [Qemu-devel] [Qemu-ppc] [PATCH v3 02/18] memory-device: introduce separate config option

[David Hildenbrand]

On 15.05.2018 17:21, Eric Blake wrote:
> On 05/14/2018 07:20 PM, Murilo Opsfelder Araujo wrote:
>> On Mon, May 14, 2018 at 12:00:07PM +0200, David Hildenbrand wrote:
>>> Some architectures might support memory devices, while they don't
>>> support DIMM/NVDIMM. So let's
>>> - Rename CONFIG_MEM_HOTPLUG to CONFIG_MEM_DEVICE
>>> - Intriduce CONFIG_DIMM and use it similarly to CONFIG NVDIMM
>>
>> Since you're resending it:
>>
>> s/Intriduce/Introduce
>>
> 
>>> +++ b/qapi/misc.json
>>> @@ -2060,7 +2060,7 @@
>>>   #
>>>   # @plugged-memory: size of memory that can be hot-unplugged. This field
>>>   #                  is omitted if target doesn't support memory hotplug
>>> -#                  (i.e. CONFIG_MEM_HOTPLUG not defined on build time).
>>> +#                  (i.e. CONFIG_MEM_DEVICE not defined on build time).
>>>   #
> 
> Also, it sounds better with: s/on/at/
> 

Yes, will include both, thanks!

-- 

Thanks,

David / dhildenb